GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — `unselectable` prop causes runtime warnings · Issue #33 · purescript-react/purescript-react-basic-dom

unselectable prop causes runtime warnings #33

New issue
Copy link
New issue
Copy link
Open
Open
unselectable prop causes runtime warnings#33
Copy link

Description

@ntwilson
ntwilson
opened on Apr 29, 2022
Issue body actions

When I make a table with unselectable: true, I get a warning from React:

Warning: Received true for a non-boolean attribute unselectable.
If you want to write it to the DOM, pass a string instead: unselectable="true" or unselectable={value.toString()}.

I'm using React & React-DOM v 17.0.2.

Would you consider changing unselectable to String? Or is there a reason that I should ignore the warning from React? It does appear that unselectable: true works, but unselectable: false doesn't. I'm guessing if the unselectable prop is present at all, it just sets it to not be selectable, despite the value you give it.
If the warning should be ignored, maybe you could consider changing unselectable to Unit, so it's more clear that it's mere presence is what affects the behavior?

Activity

  1. mjrussell commented on Jul 12, 2022

    @mjrussell
    mjrussell
    on Jul 12, 2022
    Member
    More actions

    This seems like a bug and something we should probably fix to use the string, at least before its passed into react proper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402520 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.