GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — detect_clearsky and prilliman fail on DST days, kimber fails on tz-naive data (since #2924) · Issue #2935 · pvlib/pvlib-python Open DescriptionOn main (0f6631a, pandas 3.1.0), both of these worked before #2924 and now raise: import pandas as pd import pvlib loc = pvlib.location.Location(49.28, -123.12, tz='America/Vancouver') times = pd.date_range('2026-03-07', '2026-03-10', freq='1min', tz=loc.tz, inclusive='left') ghi = loc.get_clearsky(times)['ghi'] pvlib.clearsky.detect_clearsky(ghi, ghi) # NotImplementedError: algorithm does not yet support unequal time intervals... rain = pd.Series(0.0, index=pd.date_range('2026-01-01', periods=720, freq='h')) pvlib.soiling.kimber(rain) # TypeError: Cannot convert tz-naive timestamps, use tz_localize to localize In Lines 432 to 435 in 0f6631a
Line 197 in 0f6631a
What I'd suggest: subtract the timestamps directly. That gives elapsed time for both naive and tz-aware indexes. # tools._get_sample_intervals deltas = (times[1:] - times[:-1]) / pd.Timedelta('60s') # soiling.kimber timestep_interval = rainfall.index[1] - rainfall.index[0] day_fraction = timestep_interval / pd.Timedelta(hours=24) Plus two tests: I tried this locally:
I didn't find an existing issue for this. Happy to open a PR if this sounds right. AI disclosure: I used Claude Code (an AI coding agent) to find and trace this, run the examples and tests on my machine, and draft this note. ActivityMetadataMetadataAssigneesLabelsNo labels TypeProjectsMilestoneRelationshipsDevelopmentIssue actions | ||||||||||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |