GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add support for Python 3.7 by lelit · Pull Request #73 · pypa/cibuildwheel

Conversation

@lelit

@lelit lelit commented Jun 16, 2018

Copy link
Copy Markdown
Contributor

This enables building binary wheels for Python 3.7, now at its rc1 release.

It is included in the latest manylinux1 Docker image, see pypa/manylinux#196.

Accordingly to https://www.appveyor.com/docs/build-environment/#python it is not yet available on Appveyor.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hroncok, joerick, and lelit reacted with hooray emoji
All reactions
  • 🎉 3 reactions
lelit added 2 commits June 16, 2018 13:42
@lelit
Add support for Python 3.7
9b31b5e 
This enables building binary wheels for Python 3.7, now at its rc1 release.

It is included in the latest manylinux1 Docker image, see pypa/manylinux#196.

Accordingly to https://www.appveyor.com/docs/build-environment/#python it is not yet available on Appveyor.
@lelit
Fix mistake in directory name
e5b9d1f
@lelit

lelit commented Jun 16, 2018

Copy link
Copy Markdown
Contributor Author

It fails, because the dockcross/manylinux1 images do not carry py37 yet.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joerick

joerick commented Jun 17, 2018

Copy link
Copy Markdown
Contributor

awesome work @lelit! any idea when the dockcross image will be published?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joerick
update support matrix in readme
0b21df2
@lelit

lelit commented Jun 18, 2018

Copy link
Copy Markdown
Contributor Author

No, unfortunately they pushed an update just before the standard manylinux1 gained support for 3.7, and from https://hub.docker.com/r/dockcross/manylinux-x64/tags/ it's not clear how often that happens.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@YannickJadoul

YannickJadoul commented Jun 18, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Nice! :-)
Is this urgent to include (given that AppVeyor still doesn't have it either), or could we wait 1 or 2 more weeks for the full release (cfr. https://www.python.org/dev/peps/pep-0537/)?

EDIT: Personally, I don't care about dockcross that much, to be fair. It's mainly meant to test the alternative docker image option, so we can just temporarily disable that test, as far as I'm concerned.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hroncok

hroncok commented Jun 18, 2018

Copy link
Copy Markdown
Contributor

Is this urgent to include (given that AppVeyor still doesn't have it either), or could we wait 1 or 2 more weeks for the full release

Please, release this. Getting 3.7 builds building at rc1 stage means we can find more 3.7 bugs before the actual release.
joerick reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@YannickJadoul

YannickJadoul commented Jun 18, 2018

Copy link
Copy Markdown
Member

Please, release this.

Fair enough. Let's just temporarily disable that one test, then?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lelit

lelit commented Jun 18, 2018 via email

Copy link
Copy Markdown
Contributor Author
Fair enough. Let's just temporarily disable that one test, then?
Would be it any better if we just ignore/skip unavailable versions within a given image? In that way, there would be less pressure on cibuildwheel to follow whatever Docker image one is using (I mean for example the cases when "imagexyz dropped Python 3.4"...).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@YannickJadoul

YannickJadoul commented Jun 18, 2018

Copy link
Copy Markdown
Member

Myeah, but wouldn't you want to know by having that as an error and manually disabling that version for that build, instead of silently ignoring what could be a potential oversight?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lelit

lelit commented Jun 18, 2018

Copy link
Copy Markdown
Contributor Author

Possibly yes... I was just thinking aloud (I do not use alternative manylinuxXX images myself): the question is about whether it should be always an hard error or if it could be downgraded (by default, or with an option) to a warning message instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@YannickJadoul

YannickJadoul commented Jun 18, 2018

Copy link
Copy Markdown
Member

Yes, no, sorry, didn't mean to shut that suggestion down completely, but just my 2 cents on that. Since CIBW_SKIP (and e.g. cp37-manylinux*) is so easy, I thought there's maybe something to say for "explicit is better than implicit"?
mayeut reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joerick
Skip the custom docker image specifier for Python 3.7
e3981db 
We'll reenable this when 3.7 is released and dockcross updates :)
@joerick

joerick commented Jun 18, 2018

Copy link
Copy Markdown
Contributor

Yeah, let's just disable that test on Python 3.7 for now then :)
YannickJadoul reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joerick

joerick commented Jun 18, 2018

Copy link
Copy Markdown
Contributor

The 06_docker_images test is really just there to check that the CIBW_MANYLINUX1_XXX_IMAGE options are honored, it's up to the user to create a valid config.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joerick
joerick merged commit 33433f0 into pypa:master Jun 18, 2018
@joerick

joerick commented Jun 18, 2018

Copy link
Copy Markdown
Contributor

Released as 0.9.0!
YannickJadoul reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hroncok

hroncok commented Jun 18, 2018

Copy link
Copy Markdown
Contributor

Thank You!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lelit

lelit commented Jun 19, 2018

Copy link
Copy Markdown
Contributor Author

Great, many thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lelit
lelit deleted the py37 branch June 19, 2018 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lelit @joerick @YannickJadoul @hroncok
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.