GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add drop_author parameter in methods/.../forward_messages.py, types.Message.reactions edited by kvrvgv · Pull Request #1235 · pyrogram/pyrogram

This repository was archived by the owner on Dec 23, 2024. It is now read-only.

Conversation

@kvrvgv

@kvrvgv kvrvgv commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Issue #1211

My manual tests

Expect: Default forwarding

  • 1 message with drop_author (D.A.) = None (default) - OK
  • list of messages, D.A. = None (default) - OK

Expect: Same behavior

  • 1 message, D.A. = False - OK
  • list of messages, D.A. = False (default) - OK

Expect: Forward without author account

  • 1 message, D.A. = True - OK
  • list of messages, D.A. = True (default) - OK

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lcd1232 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@kvrvgv
add drop_author parameter in methods/.../forward_messages.py
166dbff
kvrvgv
kvrvgv commented Mar 13, 2023
View reviewed changes
Comment thread pyrogram/methods/messages/forward_messages.py
schedule_date: datetime = None,
protect_content: bool = None
protect_content: bool = None,
drop_author: bool = None

@kvrvgv kvrvgv Mar 13, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function parameter
if True - author will be hidden

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kvrvgv
kvrvgv commented Mar 13, 2023
View reviewed changes
Comment thread pyrogram/methods/messages/forward_messages.py
Protects the contents of the sent message from forwarding and saving.

drop_author (``bool``, *optional*):
Forwards messages without quoting the original author

@kvrvgv kvrvgv Mar 13, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring for new param

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kvrvgv
kvrvgv commented Mar 13, 2023
View reviewed changes
Comment thread pyrogram/methods/messages/forward_messages.py
schedule_date=utils.datetime_to_timestamp(schedule_date),
noforwards=protect_content
noforwards=protect_content,
drop_author=drop_author

@kvrvgv kvrvgv Mar 13, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass parameter to raw.functions.messages.ForwardMessages

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kvrvgv and others added 2 commits May 5, 2023 18:22
@kvrvgv
Merge branch 'pyrogram:master' into master
5c6f348
@kvrvgv
fix Message.reactions type-hint error
cf2629f
kvrvgv
kvrvgv commented May 5, 2023
View reviewed changes
Comment thread pyrogram/types/messages_and_media/message.py
self.reactions = reactions
self._reactions = reactions

@property

@kvrvgv kvrvgv May 5, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

изображение

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kvrvgv kvrvgv changed the title add drop_author parameter in methods/.../forward_messages.py add drop_author parameter in methods/.../forward_messages.py, types.Message.reactions edited May 5, 2023
@lcd1232

lcd1232 commented May 22, 2023

Copy link
Copy Markdown

@delivrance could you merge it? I also tested it and it works without any issue
kvrvgv reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kvrvgv @lcd1232
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.