GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable Codecov comments by hugovk · Pull Request #432 · python/bedevere

Conversation

@hugovk

@hugovk hugovk commented Apr 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Override the global yml in https://app.codecov.io/account/gh/python/yaml:

comment: false
coverage:
  status:
    changes: false
    patch: false
    project: false

Docs: https://docs.codecov.com/docs/codecov-yaml

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk
Enable Codecov comments
742296f
@Mariatta

Mariatta commented Apr 13, 2022

Copy link
Copy Markdown
Member

Should the filename be codecov.yml without the . in front?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Apr 13, 2022

Copy link
Copy Markdown
Member Author

It can be with or without:

Can I name the file .codecov.yml?

Yes. However, the file must still be located in the repository root, dev/, or .github/ directories

https://docs.codecov.com/docs/codecov-yaml#can-i-name-the-file-codecovyml

I find it a bit neater to hide these config files with dots, but can change if you like, and/or move to .github.


Checking an earlier commit in the new "web experience", it has a link to "view yml" with it shows this with comment: false:

image

https://app.codecov.io/gh/python/bedevere/commit/4c10bf25a59089a90e3df64f2b37ab41262d12c5

Checking this PR's commit, it now says comment: true:

https://app.codecov.io/gh/python/bedevere/commit/742296fa9dd4c2e4443c931266637fad67a5dbae

codecov:
  require_ci_to_pass: true
comment: true
coverage:
  precision: 2
  range:
  - 70.0
  - 100.0
  round: down
  status:
    changes: false
    default_rules:
      flag_coverage_not_uploaded_behavior: include
    patch: false
    project: false
github_checks:
  annotations: true
Mariatta reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk
Move Codecov config to .github
d129184
@Mariatta

Mariatta commented Apr 13, 2022

Copy link
Copy Markdown
Member

Ok sounds good, lets try to merge and see if it fixes things.

ezio-melotti reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Mariatta
Mariatta merged commit ffa5eef into python:master Apr 13, 2022
@hugovk
hugovk deleted the codecov-comment-true branch April 13, 2022 17:24
@thomasrockhu-codecov

thomasrockhu-codecov commented Apr 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Tom from Codecov here. Just saw this PR and wanted to offer my help in case you ran into any issues.

Looking at the global yaml, I'd recommend changing to

comment: false
coverage:
  status:
    changes: false
    patch:
      default:
        informational: true
    project:
      default:
        informational: true

to get non-blocking status checks on PRs

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk mentioned this pull request Apr 21, 2022
Infra: add tests python/peps#2545
Merged
@ezio-melotti

ezio-melotti commented Apr 24, 2022

Copy link
Copy Markdown
Member

Hi @thomasrockhu-codecov, thanks for the suggestion!
@hugovk, can you look into this and possibly open a new issue/PR so that it doesn't get forgotten?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk mentioned this pull request Apr 25, 2022
Update Codecov global YAML #441
Closed
@hugovk

hugovk commented Apr 25, 2022

Copy link
Copy Markdown
Member Author

@ezio-melotti Done! #441

@thomasrockhu-codecov Thanks, let's try it out!

ezio-melotti reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ezio-melotti ezio-melotti mentioned this pull request May 16, 2022
Machine-parsable developers list python/devguide#848
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hugovk @Mariatta @thomasrockhu-codecov @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.