GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Disable warmups during pystats by mdboom · Pull Request #450 · python/bench_runner

Conversation

@mdboom

@mdboom mdboom commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mdboom
Disable warmups during pystats
fd8c9f9
@mdboom
mdboom requested a review from Copilot June 20, 2025 14:40
Copilot AI reviewed Jun 20, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that no warmup iterations run when collecting pystats in the benchmark script and documents that change.

  • Added a flag to disable warmups for pystats runs.
  • Updated the changelog with the new behavior.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
bench_runner/scripts/run_benchmarks.py Added --warmups 0 to extra_args to disable warmup iterations.
CHANGELOG.md Documented the “No warmups on pystats runs” change under Bugfixes.
Comments suppressed due to low confidence (1)

CHANGELOG.md:7

  • [nitpick] The phrasing is a bit awkward; consider rewording to something like: "To avoid missing statistics during warmup runs, warmups are disabled when collecting pystats."
To prevent "missing" some stats collected during warmup runs, they are now

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread bench_runner/scripts/run_benchmarks.py
os.environ[LOOPS_FILE_ENV_VAR] = "loops.json"

extra_args = ["--hook", "pystats"]
extra_args = ["--hook", "pystats", "--warmups", "0"]

Copilot AI Jun 20, 2025

Copy link

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The literal "0" here is a magic value; consider defining a named constant (e.g., WARMUPS_DISABLED) or using a configuration variable for clarity and easier updates.

Suggested change
extra_args = ["--hook", "pystats", "--warmups", "0"]
extra_args = ["--hook", "pystats", "--warmups", WARMUPS_DISABLED]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Copilot uses AI. Check for mistakes.
@mdboom
mdboom merged commit 78665ab into python:main Jun 20, 2025
@mdboom mdboom mentioned this pull request Jun 20, 2025
Revert "Disable warmups during pystats" #451
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mdboom
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.