GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add pre-commit and migrate to Ruff by savannahostrowski · Pull Request #478 · python/bench_runner

Conversation

@savannahostrowski

@savannahostrowski savannahostrowski commented May 8, 2026

Copy link
Copy Markdown
Member

I figured we could start aligning with the conventions we have in CPython: replacing black + flake8 with ruff, and adding pre-commit to streamline things and catch lint failures before they hit CI.

I haven't bumped line length to 79 here (would be a fairly mechanical 30-ish file reformat) but happy to do that if we think it's worthwhile. Also haven't touched the typechecker but would be interested in opinions on whether we should migrate from pyright to mypy.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
savannahostrowski added 4 commits May 8, 2026 12:26
@savannahostrowski
Add pre-commit, move to Ruff
4bc30e7
@savannahostrowski
Remove lint.sh
230060a
@savannahostrowski
Merge upstream main into ruff-and-precommit
0b06552
@savannahostrowski
Keep Ruff formatting at 88 columns and run hooks with prek
5debb8d
maurycy
maurycy approved these changes Nov 12, 2026
View reviewed changes
Comment thread .pre-commit-config.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/ci.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski added 2 commits November 12, 2026 12:34
@savannahostrowski
address comments
e257be1
@savannahostrowski
Merge main into ruff-and-precommit
32b321e
@maurycy maurycy mentioned this pull request Nov 12, 2026
Add zizmor and lock GitHub Actions dependencies #493
Open
@savannahostrowski
savannahostrowski merged commit a39cb74 into python:main Nov 12, 2026
6 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@maurycy maurycy maurycy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@savannahostrowski @maurycy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.