GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Sanitize slashes in benchmark result filenames by savannahostrowski · Pull Request #486 · python/bench_runner

Conversation

@savannahostrowski

@savannahostrowski savannahostrowski commented Nov 6, 2026

Copy link
Copy Markdown
Member

Another cherry-pick as I upstream fixes from my fork :)

Branch names containing / currently introduce subdirectories into generated result paths. This replaces / with _ when constructing filenames and adds a regression test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@savannahostrowski
Sanitize slashes in benchmark result filenames
4baba02
maurycy
maurycy approved these changes Nov 12, 2026
View reviewed changes
Comment thread tests/test_result.py

result = mod_result.Result.from_scratch(python, "my-fork", "jit/free-threading")
assert result.ref == "jit_free_threading"
assert result.filename.parent.parent == Path("results")

@maurycy maurycy Nov 12, 2026

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: comparing the full path assert result.filename == Path...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@maurycy maurycy maurycy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@savannahostrowski @maurycy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.