GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Retry failed benchmark result pushes by savannahostrowski · Pull Request #488 · python/bench_runner

Conversation

@savannahostrowski

@savannahostrowski savannahostrowski commented Nov 6, 2026

Copy link
Copy Markdown
Member

Another cherry-pick from my fork, with a few adjustments for upstream :)

A few months back, I encountered failed result pushes when running benchmarks across multiple machines, causing jobs to fail after the benchmarks had completed.

This PR adds up to five push attempts, rebasing before each attempt and waiting briefly between retries.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@savannahostrowski
Retry failed pushes of benchmark results
9ad27de
maurycy
maurycy approved these changes Nov 12, 2026
View reviewed changes

@maurycy maurycy left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two notes, maybe as a follow-up?

  • What do you think about just adding a new command to the bench runner? Say: python -m bench_runner push_results. This seems to be in line with

    bench_runner/CHANGELOG.md

    Line 25 in 78c5aae

    ### Moving more code to Python
  • This seems to touch only push, not touching pull.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread bench_runner/templates/_benchmark.src.yml
Comment on lines +210 to +224
if: ${{ steps.commit.outputs.committed == 'true' }}
shell: bash
run: |
branch="$GITHUB_REF_NAME"
for attempt in 1 2 3 4 5; do
echo "Push attempt $attempt to origin/$branch"
git pull --rebase origin "$branch"
if git push origin "HEAD:$branch"; then
exit 0
fi
if [ "$attempt" -lt 5 ]; then
sleep $(( RANDOM % 30 + 10 ))
fi
done
echo "Push failed after 5 attempts" >&2

@maurycy maurycy Nov 12, 2026

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is duplicate. What do you think about a YAML template like &push_step?

There are also composite actions but I don't understand them fully:

https://docs.github.com/en/actions/tutorials/create-actions/create-a-composite-action

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@maurycy maurycy maurycy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@savannahostrowski @maurycy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.