GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Validate gh-issue is int before checking range, and that gh-issue or bpo exists by hugovk · Pull Request #35 · python/blurb

Conversation

@hugovk

@hugovk hugovk commented Nov 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #34.

For the first part:

We were checking gh-issue is in the correct range (32426 or higher) before checking it's an int, and so getting a general ValueError: invalid literal for int() with base 10: '' instead of a better Blurb one: Invalid GitHub issue number! ('').

For the second part:

Ensure one of gh-issue or bpo exists in the metadata.

Also add more unit tests for Blurb.parse().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hartwork reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
hugovk added 2 commits November 9, 2024 19:26
@hugovk
Unit test Blurbs.parse
4cb4857
@hugovk
Check gh-issue- is int before checking range for better error
8e590fc 
Invalid GitHub issue number! ('one-two')

instead of:

ValueError: invalid literal for int() with base 10: 'one-two'
@hugovk hugovk mentioned this pull request Nov 9, 2024
[1.3.0] blurb crashes both with absent or empty GitHub issue (and should help with how to appraoch that case) #34
Closed
hugovk added 2 commits November 9, 2024 19:40
@hugovk
Add spaces
657a617
@hugovk
Ensure gh-issue or bpo exists in metadata
04b6913
@hugovk hugovk changed the title Validate gh-issue is int before checking range Validate gh-issue is int before checking range and gh-issue or bpo exists Nov 9, 2024
@hugovk hugovk changed the title Validate gh-issue is int before checking range and gh-issue or bpo exists Validate gh-issue is int before checking range, and that gh-issue or bpo exists Nov 9, 2024
@hugovk
Remove unused test
ac5a101
ezio-melotti
ezio-melotti reviewed Nov 10, 2024
View reviewed changes
Comment thread src/blurb/blurb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tests/test_blurb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk @ezio-melotti
Improve error wording
60f10af 
Co-authored-by: Ezio Melotti <[email protected]>
ezio-melotti
ezio-melotti approved these changes Nov 10, 2024
View reviewed changes
ezio-melotti
ezio-melotti approved these changes Nov 10, 2024
View reviewed changes
Comment thread tests/test_blurb.py
),
(
".. gh-issue: 123456\n.. section: Funky Kong\nHello world!",
r"Invalid section 'Funky Kong'! You must use one of the predefined sections",

@ezio-melotti ezio-melotti Nov 10, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you trying to get us sued by Nintendo?!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner reacted with laugh emoji
All reactions
  • 😄 1 reaction

@hugovk hugovk Nov 10, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funky Kong already lives here :D

https://github.com/python/blurb/blob/main/tests/fail/invalid-section.rst?plain=1

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
hugovk merged commit 255d115 into python:main Nov 10, 2024
@hugovk
hugovk deleted the test_parse branch November 10, 2024 10:11
@hugovk hugovk mentioned this pull request Jan 15, 2025
gh-128874: Fix the documentation for blurb 2.0 python/cpython#128875
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[1.3.0] blurb crashes both with absent or empty GitHub issue (and should help with how to appraoch that case)

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.