GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Code cleanups by hugovk · Pull Request #97 · python/blurb

Conversation

@hugovk

@hugovk hugovk commented Oct 20, 2026

Copy link
Copy Markdown
Member

Some assorted cleanups, see individual commits for details.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk added 10 commits October 20, 2026 16:18
@hugovk
str.isdecimal() guarantees int() succeeds
05a491f
@hugovk
Derive _unsanitize_section from _sanitize_section instead of maintain…
e52f7ce 
…ing both
@hugovk
Remove redundant list call
08e4dbb
@hugovk
Remove unused return and deduplicate
2763333
@hugovk
Hoist helper function to avoid redefinition in loop
20ead92
@hugovk
Remove duplicate variable
b3c212e
@hugovk
Merge imports
68ce09f
@hugovk
Remove unnecessary 'nonlocal self'
6396717
@hugovk
Fix comments
3337d62
@hugovk
Replace loop with generator expression
33efd75
StanFromIreland
StanFromIreland reviewed Oct 20, 2026
View reviewed changes
Comment thread src/blurb/_cli.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Rename test_first_line to first_line_matches
a34ac11
StanFromIreland
StanFromIreland approved these changes Oct 20, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One little nit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/blurb/_cli.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk @StanFromIreland
Remove rogue whitespace
925c3a0 
Co-authored-by: Stan Ulbrych <[email protected]>
@StanFromIreland
StanFromIreland merged commit 828b100 into python:main Oct 20, 2026
11 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk deleted the cleanup branch October 20, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.