Description

ncoghlan

opened on Jun 2, 2017

Issue body actions

The option to set the PR remote does work with cherry_picker --continue, but currently needs to be specified explicitly, rather than being remembered from the original CLI invocation.

Reacted by 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко)

Activity

1. Mariatta commented on Jun 4, 2017

   

   Mariatta

   on Jun 4, 2017

   Member

   More actions

   What --continue does right now is do git commit in the current branch (as long as it's not a master branch) then push to origin.
   If we want to remember the previously specified pr-remote then it has to be stored in a temp file or something? 🤔
2. ncoghlan commented on Jun 4, 2017

   

   ncoghlan

   on Jun 4, 2017

   ContributorAuthor

   More actions

   Aye, something along those lines. Such a file could potentially also be used to keep track of whether or not the commit step had already been completed, as before I finally realised that --pr-remote needed to be passed together with --continue, I accidentally created 3 copies of the cherry-pick commit.

   One possible option: we could add .tmp-backport/ to CPython's .gitignore file, and then use that as a working directory for temporary state in cherry_picker.py.
3. webknjaz commented on Feb 26, 2019

   

   webknjaz

   on Feb 26, 2019

   Member

   More actions

   FTR: Now with the work done in #295/#277 it should possible to implements storing more state-related data in git config --local (i.e. .git/config) throughout the whole backport cycle.

   Reacted by Mariatta
4. Mariatta

   transferred this issue frompython/core-workflowon May 30, 2019
5. CAM-Gerlach commented on Jan 15, 2023

   

   CAM-Gerlach

   on Jan 15, 2023

   Member

   More actions

   To note, the fact that this wasn't stored along with the other state was also incredibly confusing for me when attempting to reproduce #78
6. cmaloney commented on Oct 29, 2026

   

   cmaloney

   on Oct 29, 2026

   Contributor

   More actions

   Proposing that we reuse git's remote.pushDefault for this: #198

Issue actions