GeezerVison is showing github.com — Only run CI checks when appropriate files have changed · Issue #14 · python/core-workflow
Only run CI checks when appropriate files have changed #14DescriptionE.g. don't run code coverage or the test suite if only the docs changed (or vice-versa). Activityadded a commit that references this issue on Feb 14, 2017This issue will close once commit 157c0b8 is merged into the 'main' branch.157c0b8 berkerpeksag commented on Feb 14, 2017 This is now done. @brettcannon could you please close this?
Side note: Should we allow "Core developers" team to close issues on this repo? added 2 commits that reference this issue on Feb 14, 2017This issue will close once commit 8cf78fb is merged into the 'main' branch.8cf78fb This issue will close once commit 6475d73 is merged into the 'main' branch.6475d73 brettcannon commented on Feb 14, 2017 Closed and now the core team has write permissions (just simply forgot to add the team). brettcannon commented on Feb 14, 2017 And thanks for the change! I'm sure not only PR submitters appreciate the faster turn-around but I bet Travis appreciates us using less free resources. 😄 added 2 commits that reference this issue on Feb 19, 2017This issue will close once commit 3337d33 is merged into the 'main' branch.3337d33 This issue will close once commit 24bfe15 is merged into the 'main' branch.24bfe15 ammaraskar commented on Aug 11, 2017 brettcannon commented on Aug 11, 2017 It was working but it seems something has changed such that it didn't succeed in this case. ammaraskar commented on Aug 18, 2017 I've done some investigating and this is due to how Travis gets the merged code from Github.
Following the sequence of commands it used to get the repo here, it went:
git clone --depth=50 https://github.com/ammaraskar/cpython.gitgit fetch origin +refs/pull/5/mergegit checkout -qf FETCH_HEAD
I replicated these commands locally and ran git log and the problem became obvious. Github in their special refs/pull/*/merge branch creates a merge commit which means at that point this git log looks something like:
commit 472056eb60b0601dcded798229bebbddfd307945 (HEAD)
Merge: b072c6d0c6 86cece89d5
Date: Fri Aug 18 05:43:43 2017 +0000
Merge 86cece89d5c6452a92004af0276147187034d41f into b072c6d0c69849690ff03c0ce4f1911139b02ce6
commit b9ff498793611d1c6a9b99df464812931a1e2d69 (master)
Author: Elmar Ritsch <[email protected]>
Date: Fri Aug 18 05:23:51 2017 +0200
Fix broken `Show Source` links on documentation pages (GH-3113)
The `Show Source` was broken because of a change made in sphinx 1.5.1
In Sphinx 1.4.9, the sourcename was "index.txt".
In Sphinx 1.5.1+, it is now "index.rst.txt"
...
EVERY SINGLE COMMIT TO
MASTER ON A TIME AFTER
MY PR COMMIT DATE
...
commit 86cece89d5c6452a92004af0276147187034d41f
Author: Ammar Askar <[email protected]>
Date: Sat Aug 12 15:15:07 2017 -0400
Fix Linux availability version for SO_PEERSEC
And so the git diff picks up on all the commits in the middle because the PR commit ends up in a really old slot in history. brettcannon commented on Aug 18, 2017 OK, so it's basically it's imperfect but isn't hurting anything. Thanks for the detailed report, @ammaraskar ! I'm going to close this again and we can just live with occasionally building more than necessary. ammaraskar commented on Aug 18, 2017 There's a way around it, I opened up a PR to fix it: python/cpython#3129
Whether it's worth the added complexity to the build process, that I don't know. added a commit that references this issue on Jan 26, 2018This issue will close once commit df65aff is merged into the 'master' branch.df65aff added a commit that references this issue on Jan 27, 2018This issue will close once commit 130cd28 is merged into the 'master' branch.130cd28 added 2 commits that reference this issue on Jan 27, 2018This issue will close once commit b2ec361 is merged into the 'main' branch.b2ec361 This issue will close once commit 4d2dd64 is merged into the 'main' branch.4d2dd64
MetadataMetadataDevelopmentNo branches or pull requestsIssue actions
|