Description

iritkatriel

opened on Nov 27, 2022

Issue body actions

tests are as standard a requirement as doc changes. New PR authors who are not aware of this could be helped by a check failing due to lack of tests (rather than waiting for someone to comment on that, which can take years in some cases).

So the suggestion is:

Any PR that touches code must also touch the tests, or have a skip-tests label.

Reacted by Alex Waygood, Kumar Aditya, Mariatta, Ethan Furman, Erlend E. Aasland, Gregory P. Smith, Ezio Melotti and Oleg Iarygin

Activity

1. ezio-melotti

   added

   labelsIssues related to GitHub label changesIssues related to GitHub label changes

   on Nov 28, 2022
2. ezio-melotti commented on Nov 28, 2022

   

   ezio-melotti

   on Nov 28, 2022

   Member

   More actions

   It might be better to move this to python/bedevere, since he is the one performing checks related to the skip-* labels.
3. terryjreedy commented on Nov 28, 2022

   

   terryjreedy

   on Nov 28, 2022

   Member

   More actions

   AFAIK, there is no doc check/requirement, but I think there should be for enhancements. As I said on discord, I think we should at least try out both.

   Reacted by Irit Katriel
4. hugovk commented on Nov 28, 2022

   

   hugovk

   on Nov 28, 2022

   Member

   More actions

   It might be better to move this to python/bedevere, since he is the one performing checks related to the skip-* labels.

   At the sprint we talked about replacing some Bedevere functionality with more "native" GitHub stuff.

   For example, this could be done with GitHub Actions.

   @brettcannon Do you think https://github.com/brettcannon/check-for-changed-files would be suitable for this?
5. brettcannon commented on Nov 28, 2022

   

   brettcannon

   on Nov 28, 2022

   Member

   More actions

   Do you think https://github.com/brettcannon/check-for-changed-files would be suitable for this?

   Yes because that's what I designed it for. 😁 See https://github.com/microsoft/vscode-python/blob/133a8e877aa3755eaf101f1f1edf446432770b40/.github/workflows/pr-file-check.yml#L34-L43 as an example usage for this exact use case.

   Reacted by Hugo van Kemenade
6. AA-Turner commented on Aug 12, 2025

   

   AA-Turner

   on Aug 12, 2025

   Member

   More actions

   Closing, stale.
7. AA-Turner

   closed this as not plannedon Aug 12, 2025
8. hugovk commented on Aug 12, 2025

   

   hugovk

   on Aug 12, 2025

   Member

   More actions

   Let's re-open this one.
9. hugovk

   reopened this on Aug 12, 2025
10. ZeroIntensity commented on Sep 1, 2025

    

    ZeroIntensity

    on Sep 1, 2025

    Member

    More actions

    Is this something that people still want to pursue? I implemented this exact idea in Bedevere for fun a little while ago: https://github.com/ZeroIntensity/bedevere/tree/tests-check. Brett's GHA should be just as good, though.
11. AA-Turner commented on Sep 1, 2025

    

    AA-Turner

    on Sep 1, 2025

    Member

    More actions

    I'm not sure how useful it would be in reality. A 'random' sampling of the most recent 25 commits shows that only 8 needed to touch the tests. Of those 8, 1 was a pure refactor and 2 only touched the tests. I think a 'skip-tests' label would be more noise that we manually need to apply for lots of PRs.

    We could add a note about having tests for new 'feature' work in either the PR template or CONTRIBUTING.rst, neither of which mention tests at the moment.

    A

    Reacted by Shantanu

Issue actions