GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Relax click dependency. by asvetlov · Pull Request #302 · python/core-workflow

Conversation

@asvetlov

@asvetlov asvetlov commented Jan 13, 2019

Copy link
Copy Markdown
Contributor

Allow to install cherry_picker with the modern click version

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asvetlov
Relax click dependency.
33b1de7 
Allow to install cherry_picker with the modern click version
@asvetlov
asvetlov requested a review from Mariatta as a code owner January 13, 2019 13:48
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 13, 2019
@asvetlov
Fix args spec
4b55cad
willingc
willingc approved these changes Jan 13, 2019
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @asvetlov.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Mariatta
Mariatta approved these changes Jan 13, 2019
View reviewed changes
@Mariatta
Mariatta merged commit bff4148 into master Jan 13, 2019
@Mariatta
Mariatta deleted the relax-click-dependency branch January 13, 2019 19:59
@Mariatta

Mariatta commented Jan 13, 2019

Copy link
Copy Markdown
Member

Thanks! Do you need a release cut?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asvetlov

asvetlov commented Jan 13, 2019

Copy link
Copy Markdown
Contributor Author

It would be nice!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta

Mariatta commented Jan 13, 2019

Copy link
Copy Markdown
Member

Can you increase/update the version info, and the changelog?
Similar to https://github.com/python/core-workflow/pull/282/files

After that, create a GitHub tag of the release branch, and it will be automatically released to PyPI.

There's a brief write-up here: https://github.com/python/core-workflow/tree/master/cherry_picker#publishing-to-pypi
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asvetlov

asvetlov commented Jan 13, 2019

Copy link
Copy Markdown
Contributor Author

Will try
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta

Mariatta commented Jan 24, 2019

Copy link
Copy Markdown
Member

v1.2.2 is now on PyPI
willingc reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
webknjaz
webknjaz reviewed Feb 9, 2019
View reviewed changes
Comment thread cherry_picker/cherry_picker/cherry_picker.py
help=("Path to config file, .cherry_picker.toml "
"from project root by default"),
default=None)
@click.argument('commit_sha1', 'The commit sha1 to be cherry-picked', nargs=1,

@webknjaz webknjaz Feb 9, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the explanation? How is this related to the click dependency update?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@webknjaz webknjaz Feb 9, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, they changed api..

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@asvetlov asvetlov Feb 10, 2019

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly forbade meaningless argument actually. The help was never displayed IIRC

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@webknjaz webknjaz Feb 10, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nevermind. I've already figured out that it fails with this arg under newer Click: https://travis-ci.org/python/core-workflow/jobs/491106736#L270

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Mariatta Mariatta added the cherry_picker.py label May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz left review comments
@willingc willingc willingc approved these changes
@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cherry_picker.py CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@asvetlov @Mariatta @webknjaz @willingc @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.