GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Change CLA bot link from ``the-knights-who-say-ni`` to ``ambv/cla-bot`` by DanielNoord · Pull Request #469 · python/core-workflow

Conversation

DanielNoord commented Jul 8, 2022

Copy link

Copy Markdown

Contributor

Since this tool is archived and no longer used I don't think it should be in the README anymore.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Remove the-knights-who-say-ni from list of tools in README

6308b45

hugovk approved these changes

Jul 8, 2022

View reviewed changes

hugovk left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add the new CLA bot to the list?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

DanielNoord commented Jul 8, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

Perhaps add the new CLA bot to the list?

I wasn't sure which to add.

https://github.com/apps/cpython-cla-bot doesn't tell you which repository it's working from. It seems like it is https://github.com/ambv/cla-bot but I also saw posts about that repo being moved to the python org... Not sure where to link to at the moment.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk commented Jul 8, 2022

Copy link

Copy Markdown

Member

Yeah, it's at https://github.com/ambv/cla-bot.

I don't know when it's being moved, but when it is, the old link should redirect to the new location.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update to new location

10aeb03

DanielNoord commented

Jul 8, 2022

View reviewed changes

Comment thread

README.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update README.rst

11c5f59

DanielNoord changed the title ~~Remove the-knights-who-say-ni from list of tools in README~~ Change CLA bot link from the-knights-who-say-ni to amber/cla-bot

Jul 8, 2022

DanielNoord changed the title ~~Change CLA bot link from the-knights-who-say-ni to amber/cla-bot~~ Change CLA bot link from the-knights-who-say-ni to ambv/cla-bot

Jul 8, 2022

DanielNoord requested a review from hugovk

July 8, 2022 10:31

DanielNoord commented

Jul 8, 2022

View reviewed changes

Comment thread

README.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update README.rst

d77bbab

hugovk approved these changes

Jul 8, 2022

View reviewed changes

hugovk left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

DanielNoord reacted with laugh emoji

All reactions

😄 1 reaction

ezio-melotti reviewed

Jul 8, 2022

View reviewed changes

Comment thread

README.rst

		`python/the-knights-who-say-ni`_ CLA enforcement bot for `GitHub <https://github.com/ `Brett Cannon`_
		Python organization python/the-knights-who-say-ni/issues>`__
		`ambv/cla-bot`_ CLA enforcement bot for `Łukasz Langa`_
		Python organization

ezio-melotti Jul 8, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "Issue tracker" column you could add the upstream link (https://github.com/edgedb/cla-bot/issues) or a link to this repo (https://github.com/python/core-workflow/issues). @ambv, do you have any opinion on this?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

DanielNoord reacted with eyes emoji

All reactions

👀 1 reaction

ambv Jul 12, 2022

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will move ambv/cla-bot under python/cla-bot when I'm back from my July travels. I'm at EuroPython right now, are you?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ezio-melotti Jul 12, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not. Do you want to wait until the bot is moved to update and merge this?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ambv Jul 12, 2022

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge as-is and then update once it's moved.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti reacted with thumbs up emoji

All reactions

👍 1 reaction

ezio-melotti Jul 13, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged this and created #470 as a reminder for the update.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ezio-melotti merged commit 8ef33e4 into python:master

Jul 13, 2022

ezio-melotti mentioned this pull request

Jul 13, 2022

Update cla-bot entry after moving it to the python org #470

Closed

ezio-melotti mentioned this pull request

Dec 19, 2022

Update cla-bot entry after moving it to the python org #483

Closed

Reviewers

ambv

ambv left review comments

ezio-melotti

ezio-melotti left review comments

hugovk

hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

DanielNoord commented Jul 8, 2022

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

DanielNoord commented Jul 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hugovk commented Jul 8, 2022

Uh oh!

Uh oh!

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

ezio-melotti Jul 8, 2022

Choose a reason for hiding this comment

Uh oh!

ambv Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

ezio-melotti Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

ambv Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

ezio-melotti Jul 13, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DanielNoord commented Jul 8, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.