GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update fields for triage membership template by hugovk · Pull Request #491 · python/core-workflow

Conversation

@hugovk

@hugovk hugovk commented Jan 23, 2023

Copy link
Copy Markdown
Member

Remove "bpo username" from the table: even if new triagers have BPO usernames, I don't think we need this information any more.

Add "Request for Python triage membership: name" as a title for the template, so it's prefilled when creating a new request issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Update template fields
360fa33
@hugovk hugovk added the project: triagers Adding triagers project label Jan 23, 2023
@CAM-Gerlach CAM-Gerlach mentioned this pull request Jan 23, 2023
Rename default branch from "master" to "main" #492
Merged
CAM-Gerlach
CAM-Gerlach approved these changes Jan 23, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk — FYI, as this branch was created on upstream instead of your fork (presumably due to a mistake), #460 is now blocked on merging, moving or deleting this (which would prevent such by accident in the future).

Also, TIL you can add a default title—will definitely use that on python/peps#2956 (assuming it works for PRs...I honestly have no idea if anyone of it will actually work at all yet).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
This was referenced Jan 23, 2023
Adjusting the "Triager" role's permissions #460
Closed
Meta: Add templates/checklists for new, Accepted/Rejected & Final PEPs python/peps#2956
Merged
@hugovk

hugovk commented Jan 23, 2023

Copy link
Copy Markdown
Member Author

LGTM, thanks @hugovk — FYI, as this branch was created on upstream instead of your fork (presumably due to a mistake), #460 is now blocked on merging, moving or deleting this (which would prevent such by accident in the future).

Not a mistake, intentionally created via GitHub's UI for a (hopefully) quick merge :)

If this doesn't get merged in ~24h I can close and re-open on my fork, or if it's imminently blocking #460 please close this and I'll re-open later.

Also, TIL you can add a default title—will definitely use that on python/peps#2956 (assuming it works for PRs...I honestly have no idea if anyone of it will actually work at all yet).

👍 + 🤞
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra reviewed Jan 23, 2023
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/triage_membership.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Remove outdated sentence
9056c2a
AlexWaygood
AlexWaygood approved these changes Jan 23, 2023
View reviewed changes
ezio-melotti
ezio-melotti approved these changes Jan 23, 2023
View reviewed changes
@hugovk
hugovk merged commit 8eb8d10 into master Jan 23, 2023
@hugovk
hugovk deleted the update-triage-request-template branch January 23, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

project: triagers Adding triagers project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@hugovk @JelleZijlstra @CAM-Gerlach @ezio-melotti @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.