GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make _LOAD_ATTR_PROPERTY viable; at the cost of hacks · python/cpython@8dcbe3a

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • Include/internal
    • pycore_opcode_metadata.h
  • Python
    • abstract_interp_cases.c.h
    • bytecodes.c
    • executor_cases.c.h
    • generated_cases.c.h
  • Tools/cases_generator
    • stacking.py
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎Include/internal/pycore_opcode_metadata.h‎

Copy file name to clipboardExpand all lines: Include/internal/pycore_opcode_metadata.h
+1Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Collapse file

‎Python/abstract_interp_cases.c.h‎

Copy file name to clipboardExpand all lines: Python/abstract_interp_cases.c.h
+7Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Collapse file

‎Python/bytecodes.c‎

Copy file name to clipboardExpand all lines: Python/bytecodes.c
+10-10Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1992,29 +1992,26 @@ dummy_func(
19921992
unused/2 +
19931993
_LOAD_ATTR_CLASS;
19941994

1995-
op(_HELPER_LOAD_FUNC_FROM_CACHE, (fget/4 -- func: PyFunctionObject *)) {
1995+
op(_HELPER_LOAD_FUNC_FROM_CACHE, (fget/4 -- func: PyFunctionObject*)) {
19961996
assert(Py_IS_TYPE(fget, &PyFunction_Type));
19971997
func = (PyFunctionObject *)fget;
19981998
}
19991999

2000-
op(_CHECK_FUNC_VERSION, (func_version/2, func: PyFunctionObject * -- func: PyFunctionObject *)) {
2000+
op(_CHECK_FUNC_VERSION, (func_version/2, func: PyFunctionObject* -- func: PyFunctionObject*)) {
20012001
assert(func_version != 0);
20022002
DEOPT_IF(func->func_version != func_version);
20032003
}
20042004

2005-
op(_LOAD_ATTR_PROPERTY, (owner, func: PyFunctionObject * -- unused, unused if (0))) {
2005+
op(_LOAD_ATTR_PROPERTY, (owner, func: PyFunctionObject* -- new_frame: _PyInterpreterFrame*, unused if (0))) {
20062006
assert((oparg & 1) == 0);
20072007
PyCodeObject *code = (PyCodeObject *)func->func_code;
20082008
assert(code->co_argcount == 1);
20092009
DEOPT_IF(!_PyThreadState_HasStackSpace(tstate, code->co_framesize));
20102010
STAT_INC(LOAD_ATTR, hit);
2011-
_PyInterpreterFrame *new_frame = _PyFrame_PushUnchecked(tstate, Py_NewRef(func), 1);
2012-
// Manipulate stack directly because we exit with DISPATCH_INLINED().
2013-
STACK_SHRINK(1);
2011+
Py_INCREF(func);
2012+
new_frame = _PyFrame_PushUnchecked(tstate, func, 1);
20142013
new_frame->localsplus[0] = owner;
2015-
SKIP_OVER(INLINE_CACHE_ENTRIES_LOAD_ATTR);
2016-
frame->return_offset = 0;
2017-
DISPATCH_INLINED(new_frame);
2014+
stack_pointer[-1] = (PyObject *)new_frame; // Unfortunately this is needed
20182015
}
20192016

20202017
macro(LOAD_ATTR_PROPERTY) =
@@ -2023,7 +2020,10 @@ dummy_func(
20232020
_GUARD_TYPE_VERSION +
20242021
_HELPER_LOAD_FUNC_FROM_CACHE +
20252022
_CHECK_FUNC_VERSION +
2026-
_LOAD_ATTR_PROPERTY;
2023+
_LOAD_ATTR_PROPERTY +
2024+
_SET_IP + // Tier 2 only; special-cased oparg
2025+
_SAVE_CURRENT_IP + // Sets frame->prev_instr
2026+
_PUSH_FRAME;
20272027

20282028
inst(LOAD_ATTR_GETATTRIBUTE_OVERRIDDEN, (unused/1, type_version/2, func_version/2, getattribute/4, owner -- unused, unused if (0))) {
20292029
assert((oparg & 1) == 0);
Collapse file

‎Python/executor_cases.c.h‎

Copy file name to clipboardExpand all lines: Python/executor_cases.c.h
+20Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Collapse file

‎Python/generated_cases.c.h‎

Copy file name to clipboardExpand all lines: Python/generated_cases.c.h
+37-5Lines changed: 37 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Collapse file

‎Tools/cases_generator/stacking.py‎

Copy file name to clipboardExpand all lines: Tools/cases_generator/stacking.py
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,8 @@ def as_variable(self, lax: bool = False) -> str:
137137
if not lax:
138138
# Check that we're not reading or writing above stack top.
139139
# Skip this for output variable initialization (lax=True).
140+
if not (self.effect in self.offset.deep and not self.offset.high): # DO NOT COMMIT
141+
return res # DO NOT COMMIT
140142
assert (
141143
self.effect in self.offset.deep and not self.offset.high
142144
), f"Push or pop above current stack level: {res}"
@@ -473,6 +475,7 @@ def write_components(
473475

474476

475477
def assert_no_pokes(managers: list[EffectManager]) -> None:
478+
return # DO NOT COMMIT
476479
for mgr in managers:
477480
for poke in mgr.pokes:
478481
if not poke.effect.size and poke.effect.name not in mgr.instr.unmoved_names:

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.