GeezerVison is showing github.com — bpo-46648: Rewrite test_urllib2.test_issue16464() with a local HTTP s… · python/cpython@8e98175
File treeExpand file treeCollapse file tree Open diff view settings Expand file treeCollapse file tree Open diff view settings Collapse file Copy file name to clipboardExpand all lines: Lib/test/test_urllib2.py -18Lines changed: 0 additions & 18 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -1788,24 +1788,6 @@ class MyOtherHTTPHandler(urllib.request.HTTPHandler): | 1788 | 1788 | self.opener_has_handler(o, MyHTTPHandler) | 1789 | 1789 | self.opener_has_handler(o, MyOtherHTTPHandler) | 1790 | 1790 |
| 1791 | | - @unittest.skipUnless(support.is_resource_enabled('network'), | 1792 | | - 'test requires network access') | 1793 | | - # bpo-46648: test fails randomly with "http://www.example.com/" URL | 1794 | | - @unittest.skipIf(True, "POST request to http://www.example.com/ fail randomly") | 1795 | | - def test_issue16464(self): | 1796 | | - with socket_helper.transient_internet("http://www.example.com/"): | 1797 | | - opener = urllib.request.build_opener() | 1798 | | - request = urllib.request.Request("http://www.example.com/") | 1799 | | - self.assertEqual(None, request.data) | 1800 | | - | 1801 | | - opener.open(request, "1".encode("us-ascii")) | 1802 | | - self.assertEqual(b"1", request.data) | 1803 | | - self.assertEqual("1", request.get_header("Content-length")) | 1804 | | - | 1805 | | - opener.open(request, "1234567890".encode("us-ascii")) | 1806 | | - self.assertEqual(b"1234567890", request.data) | 1807 | | - self.assertEqual("10", request.get_header("Content-length")) | 1808 | | - | 1809 | 1791 | def test_HTTPError_interface(self): | 1810 | 1792 | """ | 1811 | 1793 | Issue 13211 reveals that HTTPError didn't implement the URLError | |
Collapse file Copy file name to clipboardExpand all lines: Lib/test/test_urllib2_localnet.py +18Lines changed: 18 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -660,6 +660,24 @@ def test_line_iteration(self): | 660 | 660 | (index, len(lines[index]), len(line))) | 661 | 661 | self.assertEqual(index + 1, len(lines)) | 662 | 662 |
| | 663 | + def test_issue16464(self): | | 664 | + # See https://bugs.python.org/issue16464 | | 665 | + # and https://bugs.python.org/issue46648 | | 666 | + handler = self.start_server([ | | 667 | + (200, [], b'any'), | | 668 | + (200, [], b'any'), | | 669 | + ]) | | 670 | + opener = urllib.request.build_opener() | | 671 | + request = urllib.request.Request("http://localhost:%s" % handler.port) | | 672 | + self.assertEqual(None, request.data) | | 673 | + | | 674 | + opener.open(request, "1".encode("us-ascii")) | | 675 | + self.assertEqual(b"1", request.data) | | 676 | + self.assertEqual("1", request.get_header("Content-length")) | | 677 | + | | 678 | + opener.open(request, "1234567890".encode("us-ascii")) | | 679 | + self.assertEqual(b"1234567890", request.data) | | 680 | + self.assertEqual("10", request.get_header("Content-length")) | 663 | 681 |
| 664 | 682 | def setUpModule(): | 665 | 683 | thread_info = threading_helper.threading_setup() | |
|