@@ -3719,8 +3719,9 @@ def test_startupinfo(self): |
3719 | 3719 | # Since Python is a console process, it won't be affected |
3720 | 3720 | # by wShowWindow, but the argument should be silently |
3721 | 3721 | # ignored |
3722 | | - subprocess.call(ZERO_RETURN_CMD, |
3723 | | - startupinfo=startupinfo) |
| 3722 | + rc = subprocess.call(ZERO_RETURN_CMD, |
| 3723 | + startupinfo=startupinfo) |
| 3724 | + self.assertEqual(rc, 0) |
3724 | 3725 |
|
3725 | 3726 | def test_startupinfo_keywords(self): |
3726 | 3727 | # startupinfo argument |
@@ -3735,8 +3736,9 @@ def test_startupinfo_keywords(self): |
3735 | 3736 | # Since Python is a console process, it won't be affected |
3736 | 3737 | # by wShowWindow, but the argument should be silently |
3737 | 3738 | # ignored |
3738 | | - subprocess.call(ZERO_RETURN_CMD, |
3739 | | - startupinfo=startupinfo) |
| 3739 | + rc = subprocess.call(ZERO_RETURN_CMD, |
| 3740 | + startupinfo=startupinfo) |
| 3741 | + self.assertEqual(rc, 0) |
3740 | 3742 |
|
3741 | 3743 | def test_startupinfo_copy(self): |
3742 | 3744 | # bpo-34044: Popen must not modify input STARTUPINFO structure |
@@ -3853,14 +3855,16 @@ def test_close_fds_with_stdio(self): |
3853 | 3855 | def test_empty_attribute_list(self): |
3854 | 3856 | startupinfo = subprocess.STARTUPINFO() |
3855 | 3857 | startupinfo.lpAttributeList = {} |
3856 | | - subprocess.call(ZERO_RETURN_CMD, |
3857 | | - startupinfo=startupinfo) |
| 3858 | + rc = subprocess.call(ZERO_RETURN_CMD, |
| 3859 | + startupinfo=startupinfo) |
| 3860 | + self.assertEqual(rc, 0) |
3858 | 3861 |
|
3859 | 3862 | def test_empty_handle_list(self): |
3860 | 3863 | startupinfo = subprocess.STARTUPINFO() |
3861 | 3864 | startupinfo.lpAttributeList = {"handle_list": []} |
3862 | | - subprocess.call(ZERO_RETURN_CMD, |
3863 | | - startupinfo=startupinfo) |
| 3865 | + rc = subprocess.call(ZERO_RETURN_CMD, |
| 3866 | + startupinfo=startupinfo) |
| 3867 | + self.assertEqual(rc, 0) |
3864 | 3868 |
|
3865 | 3869 | def test_shell_sequence(self): |
3866 | 3870 | # Run command through the shell (sequence) |
@@ -3871,6 +3875,8 @@ def test_shell_sequence(self): |
3871 | 3875 | env=newenv) |
3872 | 3876 | with p: |
3873 | 3877 | self.assertIn(b"physalis", p.stdout.read()) |
| 3878 | + p.communicate() |
| 3879 | + self.assertEqual(p.returncode, 0) |
3874 | 3880 |
|
3875 | 3881 | def test_shell_string(self): |
3876 | 3882 | # Run command through the shell (string) |
@@ -3881,6 +3887,8 @@ def test_shell_string(self): |
3881 | 3887 | env=newenv) |
3882 | 3888 | with p: |
3883 | 3889 | self.assertIn(b"physalis", p.stdout.read()) |
| 3890 | + p.communicate() |
| 3891 | + self.assertEqual(p.returncode, 0) |
3884 | 3892 |
|
3885 | 3893 | def test_shell_encodings(self): |
3886 | 3894 | # Run command through the shell (string) |
@@ -3893,6 +3901,8 @@ def test_shell_encodings(self): |
3893 | 3901 | encoding=enc) |
3894 | 3902 | with p: |
3895 | 3903 | self.assertIn("physalis", p.stdout.read(), enc) |
| 3904 | + p.communicate() |
| 3905 | + self.assertEqual(p.returncode, 0) |
3896 | 3906 |
|
3897 | 3907 | def test_call_string(self): |
3898 | 3908 | # call() function with string argument on Windows |
|