GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-134262: Fix off by one errors in download retry functions (GH-134867) · python/cpython@e64395e

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

PCbuild
- get_external.py
Tools/build
- generate_sbom.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎PCbuild/get_external.py‎`

Copy file name to clipboardExpand all lines: PCbuild/get_external.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`def retrieve_with_retries(download_location, output_path, reporthook,`
`13`	`13`	`max_retries=7):`
`14`	`14`	`"""Download a file with exponential backoff retry and save to disk."""`
`15`		`- for attempt in range(max_retries):`
	`15`	`+ for attempt in range(max_retries + 1):`
`16`	`16`	`try:`
`17`	`17`	`resp = urlretrieve(`
`18`	`18`	`download_location,`

Collapse file

`‎Tools/build/generate_sbom.py‎`

Copy file name to clipboardExpand all lines: Tools/build/generate_sbom.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ def download_with_retries(download_location: str,`
`169`	`169`	`base_delay: float = 2.25,`
`170`	`170`	`max_jitter: float = 1.0) -> typing.Any:`
`171`	`171`	`"""Download a file with exponential backoff retry."""`
`172`		`- for attempt in range(max_retries):`
	`172`	`+ for attempt in range(max_retries + 1):`
`173`	`173`	`try:`
`174`	`174`	`resp = urllib.request.urlopen(download_location)`
`175`	`175`	`except urllib.error.URLError as ex:`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.