GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101152: Implement PEP 699 by ramvikrams · Pull Request #101193 · python/cpython

Conversation

@ramvikrams

@ramvikrams ramvikrams commented Jan 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

gh-101152: Added the PEP 699 Implementation

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ramvikrams
PEP 699 Implementation
afd678c
@bedevere-bot bedevere-bot added the awaiting review label Jan 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 20, 2023
PEP 699: Implementation #101152
Closed
@ramvikrams
corrected a spelling mistake
26ad50a
@kumaraditya303 kumaraditya303 assigned Fidget-Spinner Jan 20, 2023
@Fidget-Spinner

Fidget-Spinner commented Jan 21, 2023

Copy link
Copy Markdown
Member
  1. Please add news.
  2. The code looks similar to Kumar's. I'll add him as co-author when I merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@blurb-it
📜🤖 Added by blurb_it.
ff3bcc5
@ramvikrams

ramvikrams commented Jan 21, 2023

Copy link
Copy Markdown
Contributor Author
  1. Please add news.
  2. The code looks similar to Kumar's. I'll add him as co-author when I merge.

added the news and infact it is a replica of his solution

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Fidget-Spinner
Fidget-Spinner reviewed Jan 21, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Build/2023-01-21-10-31-35.gh-issue-101152.xvM8pL.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

ramvikrams added 3 commits January 21, 2023 17:55
@ramvikrams
added whatsnew entry
2ce45cc
@ramvikrams
Update 3.12.rst
5e4b310
@ramvikrams
Update 2023-01-21-10-31-35.gh-issue-101152.xvM8pL.rst
f7c8293
Fidget-Spinner
Fidget-Spinner reviewed Jan 21, 2023
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some feedback for your future contributions:

  1. You can close conversations. Click on the "resolve conversation" button once you feel that you resolved the comment.
  2. reStructuredText markup is a little tricky! So you can refer to the devguide for that https://devguide.python.org/documentation/markup/
  3. I'll try to summarise what I look for in the Whats New deprecation. First you want to know exactly what is being affected (in this case the field of a certain struct being deprecated). Secondly, you want to know, without ambiguity, how we will notify users of this deprecation. In this case it's a compiler warning. Lastly, if there's a planned removal version for the deprecated thing, it should be mentioned too.

Thank you.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Misc/NEWS.d/next/Build/2023-01-21-10-31-35.gh-issue-101152.xvM8pL.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Fidget-Spinner Fidget-Spinner changed the title gh-101152: Added the PEP 699 Implementation gh-101152: Implement PEP 699 Jan 21, 2023
ramvikrams and others added 2 commits January 21, 2023 21:27
@ramvikrams @Fidget-Spinner
Update Doc/whatsnew/3.12.rst
a799bfb
Co-authored-by: Ken Jin <[email protected]>
@ramvikrams @Fidget-Spinner
Update Misc/NEWS.d/next/Build/2023-01-21-10-31-35.gh-issue-101152.xvM…
8b88d8e
…8pL.rst

Co-authored-by: Ken Jin <[email protected]>
@ramvikrams

ramvikrams commented Jan 21, 2023

Copy link
Copy Markdown
Contributor Author

Just some feedback for your future contributions:

The feedback was very helpful, will surely keep the points in mind.

Thanks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Fidget-Spinner
Fidget-Spinner reviewed Jan 21, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

ramvikrams added 2 commits January 21, 2023 22:15
@ramvikrams
Update 2023-01-21-10-31-35.gh-issue-101152.xvM8pL.rst
f292522
@ramvikrams
Update 3.12.rst
59b541d
Fidget-Spinner
Fidget-Spinner reviewed Jan 22, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Fidget-Spinner
Fidget-Spinner requested a review from kumaraditya303 January 22, 2023 14:29
ramvikrams and others added 2 commits January 22, 2023 20:16
@ramvikrams @Fidget-Spinner
Update Doc/whatsnew/3.12.rst
fcf97e5
Co-authored-by: Ken Jin <[email protected]>
@ramvikrams
Update 2023-01-21-10-31-35.gh-issue-101152.xvM8pL.rst
b40f727
kumaraditya303
kumaraditya303 approved these changes Jan 23, 2023
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 23, 2023
@Fidget-Spinner

Fidget-Spinner commented Jan 23, 2023

Copy link
Copy Markdown
Member

Can you rebase with main and fix the conflicts in 3.12 whats new please? Seems like someone wrote an entry at the current spot.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ramvikrams

ramvikrams commented Jan 23, 2023

Copy link
Copy Markdown
Contributor Author

Can you rebase with main and fix the conflicts in 3.12 whats new please? Seems like someone wrote an entry at the current spot.

yes sure

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ramvikrams
Merge branch 'main' into t001
eb4dc55
ramvikrams added 2 commits January 23, 2023 22:31
@ramvikrams
Update 3.12.rst
289e18b
@ramvikrams
Update 3.12.rst
cd658de
Fidget-Spinner
Fidget-Spinner approved these changes Jan 23, 2023
View reviewed changes
@ramvikrams
Merge branch 'main' into t001
a0eb046
@Fidget-Spinner
Fidget-Spinner merged commit 7f95ec3 into python:main Jan 24, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 24, 2023
@ramvikrams
ramvikrams deleted the t001 branch January 24, 2023 10:42
@vstinner vstinner mentioned this pull request Sep 22, 2023
What's New in Python 3.12 (copyediting) #109190
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Fidget-Spinner Fidget-Spinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ramvikrams @Fidget-Spinner @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.