Description

pitrou

opened on Oct 14, 2023

Issue body actions

Feature or enhancement

Proposal:

The following C API functions would be nice to have and probably easy to provide.

PyAPI_FUNC(PyObject *) PyLong_FromIntptr_t(Py_intptr_t);
PyAPI_FUNC(PyObject *) PyLong_FromUintptr_t(Py_uintptr_t);

PyAPI_FUNC(Py_intptr_t) PyLong_AsInptr_t(PyObject *);
PyAPI_FUNC(Py_uintptr_t) PyLong_AsUinptr_t(PyObject *);

Note that the given integers types should exist, as they have official counterparts in C99.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

There is a discussion of a similar feature in #62070, but I would argue that intptr_t and uintptr_t are much more common in real life that intmax_t.

Activity

1. pitrou

   added

   type-featureA feature request or enhancementA feature request or enhancement

   topic-C-API

   interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

   easy

   on Oct 14, 2023
2. Lincoln-developer commented on Oct 16, 2023

   

   Lincoln-developer

   on Oct 16, 2023

   Contributor

   More actions

   Hey, I would love to work on this if you don't mind.
3. pitrou commented on Oct 16, 2023

   

   pitrou

   on Oct 16, 2023

   MemberAuthor

   More actions

   @encukou Does this enhancement sound like a good idea? If so, @Lincoln-developer would like to work on it.
4. Lincoln-developer commented on Oct 18, 2023

   

   Lincoln-developer

   on Oct 18, 2023

   Contributor

   More actions

   @pitrou , are we waiting for @encukou's response on this then I start working on the issue, just inquiring. Thanks
5. encukou commented on Oct 18, 2023

   

   encukou

   on Oct 18, 2023

   Member

   More actions

   Thanks for the propoal.
   As we're forming a C-API working group to guide the evolution of the C-API, I'd prefer the proposal to be discussed on Discourse first.
   Do we continue to add functions similar to the ones we already have, which are OK but could be improved, or should we switch to a new style now?

   • These functions have an ambiguous return value: when -1 is returned, the caller needs to check PyErr_Occurred. This is problematic, and against a proposed guideline. Of course, we make an exception in the name of consistency with the existing API -- but a discussion is in order.
   • We already have PyLong_{From,As}VoidPtr and PyLong_{From,As}[U]IntMax_t, which should be enough in practice. Is there a use case where these won't work? That would be a reason to add the API ASAP.
   • I'd argue that new API should use intptr_t directly, and the pre-C99 typedefs like Py_intptr_t should be phased out.
6. encukou

   removed

   easy

   on Jul 13, 2024
7. vstinner commented on Jan 27, 2025

   

   vstinner

   on Jan 27, 2025

   Member

   More actions

   Somehow related, Python 3.14 adds the following functions:

   • PyLong_AsInt32()
   • PyLong_AsInt64()
   • PyLong_AsUInt32()
   • PyLong_AsUInt64()
   • PyLong_FromInt32()
   • PyLong_FromInt64()
   • PyLong_FromUInt32()
   • PyLong_FromUInt64()

   Reacted by Erlend E. Aasland
8. vstinner commented on Jan 28, 2025

   

   vstinner

   on Jan 28, 2025

   Member

   More actions

   See also issue gh-62070 for PyLong_FromIntMax_t() and PyLong_FromUintMax_t().
9. encukou commented on Jan 28, 2025

   

   encukou

   on Jan 28, 2025

   Member

   More actions

   Since 3.13 you can use PyLong_{From,To}NativeBytes with sizeof(intptr_t). Is that enough for your use case?

   Reacted by Victor Stinner
10. encukou commented on Feb 4, 2025

    

    encukou

    on Feb 4, 2025

    Member

    More actions

    If not, please reopen :)
11. encukou

    closed this as completedon Feb 4, 2025

Issue actions