GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-113174: Sync with importlib_metadata 7.0 by jaraco · Pull Request #113175 · python/cpython

Conversation

jaraco commented Dec 15, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Apply changes from importlib_metadata for Python 3.13 #113174

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot mentioned this pull request

Dec 15, 2023

Apply changes from importlib_metadata for Python 3.13 #113174

Closed

1 task done

hugovk commented Dec 15, 2023

Copy link

Copy Markdown

Member

Sync with importlib_metadata 7.0, including improved type annotations, fixed
issue with symlinked packages in package_distributions, added
EntryPoints.__repr__, introduced the diagnose script, added
Distribution.origin property, and removed deprecated EntryPoint
access by numeric index (tuple behavior).

Will there be docs changes in this PR or another?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaraco commented Dec 15, 2023

Copy link

Copy Markdown

Member Author

Will there be docs changes in this PR or another?

I've added docs in b610b6d. I chose not to mention some of the changes as they seemed incidental enough not to affect most users.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaraco marked this pull request as ready for review

December 15, 2023 15:13

jaraco requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners

December 15, 2023 15:13

bedevere-app Bot added the awaiting core review label

Dec 15, 2023

hugovk reviewed

Dec 15, 2023

View reviewed changes

hugovk left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this also benefit from an entry in What's New in Python 3.13?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/importlib.metadata.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/importlib.metadata.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/importlib.metadata.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

jaraco added 3 commits

December 15, 2023 11:16


          Sync with importlib_metadata 7.0.0

509b831


          Add blurb

9f77bda


          Update docs to reflect changes.

aa23e5a

jaraco force-pushed the feature/113174-importlib-metadata-7.0 branch from 5914c78 to aa23e5a Compare

December 15, 2023 16:16

jaraco commented Dec 15, 2023

Copy link

Copy Markdown

Member Author

Would this also benefit from an entry in What's New in Python 3.13?

Perhaps. I'd consider mentioning the EntryPoint.__getitem__ removal and new Distribution.origin property, though I expect most users not to care much. Overall, I'm thinking it'd be more noise than value, so I'll propose not to add anything, but I'd be happy to add something if anyone feels otherwise.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood reviewed

Dec 19, 2023

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @hugovk that the removal of EntryPoint.__getitem__ should be mentioned in "What's New". It doesn't need to be a prominent mention near the top of the document, but we should try to make sure that all backwards-incompatible changes are mentioned somewhere in that document, in my opinion.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaraco reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

Doc/library/importlib.metadata.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

brettcannon removed their request for review

December 19, 2023 19:18

jaraco and others added 3 commits

December 21, 2023 14:09


          Link datamodel docs for object.__getitem__

f471421

Co-authored-by: Alex Waygood <[email protected]>


          Merge branch 'main' into feature/113174-importlib-metadata-7.0

f06d128


          Add what's new for removed __getattr__

c766239

AlexWaygood reviewed

Dec 21, 2023

View reviewed changes

Comment thread

Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

jaraco and others added 2 commits

December 21, 2023 14:27


          Link datamodel docs for object.__getitem__

988f41e

Co-authored-by: Alex Waygood <[email protected]>


          Add exclamation point, as that seems to be used for other classes.

2cc2b7a

jaraco commented Dec 21, 2023

Copy link

Copy Markdown

Member Author

Today I learned about the syntax (docs). The exclamation point means to ignore EntryPoint because it isn't documented.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaraco removed request for ericsnowcurrently, ncoghlan and warsaw

December 21, 2023 19:41

jaraco commented Dec 21, 2023

Copy link

Copy Markdown

Member Author

Thanks for the review. Merging, but happy to revisit if needed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaraco merged commit 2d91409 into python:main

Dec 21, 2023

bedevere-app Bot removed the awaiting core review label

Dec 21, 2023

jaraco deleted the feature/113174-importlib-metadata-7.0 branch

December 21, 2023 20:04

ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request

Dec 26, 2023


          pythongh-113174: Sync with importlib_metadata 7.0 (python#113175)

8b200cb

* Sync with importlib_metadata 7.0.0

* Add blurb

* Update docs to reflect changes.

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add what's new for removed __getattr__

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add exclamation point, as that seems to be used for other classes.

---------

Co-authored-by: Alex Waygood <[email protected]>

ambv commented Jan 2, 2024

Copy link

Copy Markdown

Contributor

There's some tests that are failing on Windows for this change. The build that introduced the failure is the one with this PR merged:
https://buildbot.python.org/all/#/builders/1079/builds/3009

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ambv commented Jan 14, 2024

Copy link

Copy Markdown

Contributor

I worked around the problem by enabling SeCreateSymbolicLinkPrivilege for the buildbot user, but ultimately I believe the test should be skipped for users without this privilege set.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request

Jan 22, 2024


          pythongh-113174: Sync with importlib_metadata 7.0 (python#113175)

* Sync with importlib_metadata 7.0.0

* Add blurb

* Update docs to reflect changes.

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add what's new for removed __getattr__

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add exclamation point, as that seems to be used for other classes.

---------

Co-authored-by: Alex Waygood <[email protected]>

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024


          pythongh-113174: Sync with importlib_metadata 7.0 (python#113175)

8fa3c93

* Sync with importlib_metadata 7.0.0

* Add blurb

* Update docs to reflect changes.

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add what's new for removed __getattr__

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add exclamation point, as that seems to be used for other classes.

---------

Co-authored-by: Alex Waygood <[email protected]>

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          pythongh-113174: Sync with importlib_metadata 7.0 (python#113175)

6daac7f

* Sync with importlib_metadata 7.0.0

* Add blurb

* Update docs to reflect changes.

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add what's new for removed __getattr__

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add exclamation point, as that seems to be used for other classes.

---------

Co-authored-by: Alex Waygood <[email protected]>

hugovk mentioned this pull request

Mar 30, 2025

Improve import time of various stdlib modules #118761

Closed

Reviewers

hugovk

hugovk left review comments

AlexWaygood

AlexWaygood left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

jaraco commented Dec 15, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hugovk commented Dec 15, 2023

Uh oh!

jaraco commented Dec 15, 2023

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaraco commented Dec 15, 2023

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jaraco commented Dec 21, 2023

Uh oh!

jaraco commented Dec 21, 2023

Uh oh!

ambv commented Jan 2, 2024

Uh oh!

ambv commented Jan 14, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jaraco commented Dec 15, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.