GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — gh-113812: Allow DatagramTransport.sendto to send empty data by ordinary-jamie · Pull Request #115199 · python/cpython Conversation
|
|
@gvanrossum -- This might cause an issue with the flow control of the transport. Since the buffer size is calculated with only the payload (and not the entire datagram). The write buffer could in theory be flooded with zero-length datagrams, and the high watermark will never be crossed. cpython/Lib/asyncio/selector_events.py Line 1279 in 67d6bed
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Oh, that's a very good point. I think we could add a constant value to the "buffer size" for each packet added -- the only use for the buffer size is to interact with flow control. In fact, after skimming the UDP Wikipedia page, I think we can add 8 for each packet, since that's the protocol's header size. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's do something about flow control first.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LG -- I'll merge now!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, I'd like one more doc change. The code and docs are actually fine, but I feel this deserves a What's New entry (Doc/whatsnew/3.13.rst). A bullet in the existing |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
No worries :) Let me know what you think of this wording I just added! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will merge later tonight.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Sorry Guido, just pushed a documentation change to for the version change note in the Documentation Edit: Also pushed a typo fix (repeated "will now") sorry! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks again, @ordinary-jamie! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ython#115199) Also include the UDP packet header sizes (8 bytes per packet) in the buffer size reported to the flow control subsystem.
…ython#115199) Also include the UDP packet header sizes (8 bytes per packet) in the buffer size reported to the flow control subsystem.
…ython#115199) Also include the UDP packet header sizes (8 bytes per packet) in the buffer size reported to the flow control subsystem.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.