GeezerVison is showing github.com — Should we allow relative includes? (i.e. #include "../_ssl.h") · Issue #121223 · python/cpython
Should we allow relative includes? (i.e. #include "../_ssl.h") #121223DescriptionFeature or enhancement
Proposal:
Can we avoid the relative include? They tend to produce problems further down the road.
Originally posted by @erlend-aasland in #120894 (comment)
There are few more examples:
$ git grep '#include .*\.\.\/'
Include/internal/mimalloc/mimalloc/track.h:#include "../src/prim/windows/etw.h"
Modules/_blake2/blake2b_impl.c:#include "../hashlib.h"
Modules/_blake2/blake2s_impl.c:#include "../hashlib.h"
Modules/_ctypes/callproc.c:#include "../_complex.h" // complex
Modules/_hacl/internal/Hacl_Hash_MD5.h:#include "../Hacl_Hash_MD5.h"
Modules/_hacl/internal/Hacl_Hash_SHA1.h:#include "../Hacl_Hash_SHA1.h"
Modules/_hacl/internal/Hacl_Hash_SHA2.h:#include "../Hacl_Hash_SHA2.h"
Modules/_hacl/internal/Hacl_Hash_SHA3.h:#include "../Hacl_Hash_SHA3.h"
Modules/_ssl/cert.c:#include "../_ssl.h"
Modules/_ssl/misc.c:#include "../_ssl.h"
Modules/_testinternalcapi/set.c:#include "../_testcapi/util.h" // NULLABLE, RETURN_INT
Objects/mimalloc/prim/osx/prim.c:#include "../unix/prim.c"
Parser/lexer/lexer.c:#include "../tokenizer/helpers.h"
Parser/tokenizer/file_tokenizer.c:#include "../lexer/state.h"
Parser/tokenizer/file_tokenizer.c:#include "../lexer/lexer.h"
Parser/tokenizer/file_tokenizer.c:#include "../lexer/buffer.h"
Parser/tokenizer/helpers.c:#include "../lexer/state.h"
Parser/tokenizer/helpers.h:#include "../lexer/state.h"
Parser/tokenizer/readline_tokenizer.c:#include "../lexer/lexer.h"
Parser/tokenizer/readline_tokenizer.c:#include "../lexer/state.h"
Parser/tokenizer/readline_tokenizer.c:#include "../lexer/buffer.h"
Parser/tokenizer/string_tokenizer.c:#include "../lexer/state.h"
Parser/tokenizer/utf8_tokenizer.c:#include "../lexer/state.h"
Python/Python-tokenize.c:#include "../Parser/lexer/state.h"
Python/Python-tokenize.c:#include "../Parser/lexer/lexer.h"
Python/Python-tokenize.c:#include "../Parser/tokenizer/tokenizer.h"
Python/Python-tokenize.c:#include "../Parser/pegen.h" // _PyPegen_byte_offset_to_character_offset()
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response Activitykumaraditya303 commented on Jul 3, 2024 Note that mimalloc is copied from upstream, I don't think we should be changing it here. Reacted by Erlend E. Aasland picnixz commented on Jul 15, 2025 vstinner commented on Aug 5, 2025 It seems like we have multiple C files using relative includes, and I'm not aware of any practical issue, so I suggest to simply closing this issue. skirpichev commented on Aug 5, 2025 @erlend-aasland, could you more elaborate about problems, mentioned in your comment? erlend-aasland commented on Aug 6, 2025
@erlend-aasland, could you more elaborate about problems, mentioned in your comment?
I don't remember the reason for raising this issue. I'm fine with closing the issue, as Victor suggests.
MetadataMetadataDevelopmentNo branches or pull requestsIssue actions
|