Description

mgorny

opened on Oct 2, 2024

Issue body actions

Crash report

What happened?

The 49f6beb ("Make interned strings mortal") backport introduced ABI-breaking assertions into 3.12.7. As a result, Rust stable ABI packages are now crashing on assertions, e.g. from uv's cargo test:

          5 │+python3: Objects/unicodeobject.c:15018: intern_common: Assertion `_Py_IsImmortal(r)' failed.
          6 │+python3: Objects/unicodeobject.c:15018: intern_common: Assertion `_Py_IsImmortal(r)' failed.

Backporting 281ffb6 seems to fix the immediate issue but I haven't checked for more regressions.

CPython versions tested on:

3.12

Operating systems tested on:

Linux

Output from running 'python -VV' on the command line:

Python 3.12.7 (main, Oct 1 2024, 21:49:30) [GCC 14.2.1 20240921]

Activity

1. mgorny

   added

   type-crashA hard crash of the interpreter, possibly with a core dumpA hard crash of the interpreter, possibly with a core dump

   on Oct 2, 2024
2. ZeroIntensity

   added

   topic-C-API

   3.12only security fixesonly security fixes

   on Oct 2, 2024
3. ZeroIntensity commented on Oct 2, 2024

   

   ZeroIntensity

   on Oct 2, 2024

   Member

   More actions

   Ah, this problem again. assert(_Py_IsImmortal(...)) breaks stable ABI extensions -- we're supposed to use assert(_Py_IsImmortalLoose(...)). IIRC, that PR took a while to backport, so there's a chance that it predated _Py_IsImmortalLoose. cc @encukou
4. encukou

   self-assigned this

   on Oct 3, 2024
5. encukou commented on Oct 3, 2024

   

   encukou

   on Oct 3, 2024

   Member

   More actions

   I missed this in the big backport. My apologies :(
6. encukou commented on Oct 4, 2024

   

   encukou

   on Oct 4, 2024

   Member

   More actions

   I've merged the backport: #124938

   Reacted by Peter Bierma
7. encukou

   closed this as completedon Oct 4, 2024
8. mgorny commented on Oct 4, 2024

   

   mgorny

   on Oct 4, 2024

   ContributorAuthor

   More actions

   Thank you!

Issue actions