GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-125542: Deprecate `prefix_chars` in `ArgumentParser.add_argument_group` by savannahostrowski · Pull Request #125563 · python/cpython

Conversation

@savannahostrowski

@savannahostrowski savannahostrowski commented Oct 16, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

📚 Documentation preview 📚: https://cpython-previews--125563.org.readthedocs.build/

  • Issue: Deprecate prefix_chars in argument_group #125542

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
savannahostrowski added 2 commits October 15, 2024 21:46
@savannahostrowski
Deprecate prefix_chars
bd26604
@savannahostrowski
Remove extraneous comment
0763efb
@savannahostrowski
savannahostrowski requested a review from serhiy-storchaka October 16, 2024 04:48
@bedevere-app bedevere-app Bot added the awaiting review label Oct 16, 2024
@savannahostrowski savannahostrowski changed the title Deprecate prefix_chars in ArgumentParser.add_argument_group gh-125542: Deprecate prefix_chars in ArgumentParser.add_argument_group Oct 16, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 16, 2024
Deprecate prefix_chars in argument_group #125542
Closed
savannahostrowski and others added 5 commits October 15, 2024 21:49
@savannahostrowski
Add GH number to whatsnew
fd1cd64
@blurb-it
📜🤖 Added by blurb_it.
faf7699
@savannahostrowski
Remove newline
f105c3e
@savannahostrowski
Merge branch 'pythongh-125542' of https://github.com/savannahostrowsk…
d6b41c5 
…i/cpython into pythongh-125542
@savannahostrowski
Appease linter
b5f2355
@savannahostrowski

savannahostrowski commented Oct 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@serhiy-storchaka I wasn't sure if this should be considered more of a soft deprecation (targeting slated removal in 3.16 or similar) since I'm not really changing logic here to ignore this parameter/throw an error. Interested to hear your thoughts!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski added 2 commits October 15, 2024 22:20
@savannahostrowski
Fix reference
7c0c570
@savannahostrowski
Update deprecation in docs for consistency
86d91ef
savannahostrowski
savannahostrowski commented Oct 16, 2024
View reviewed changes
Comment thread Doc/library/argparse.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski
Use func
5897e0a
serhiy-storchaka
serhiy-storchaka reviewed Oct 16, 2024
View reviewed changes
Comment thread Doc/library/argparse.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/argparse.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/argparse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_argparse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_argparse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_argparse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2024-10-16-04-50-53.gh-issue-125542.vZJ-Ns.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski added 2 commits October 16, 2024 19:45
@savannahostrowski
Address PR comments
3d0ddf3
@savannahostrowski
Use double backtick syntax
d3a2f41
@savannahostrowski

savannahostrowski commented Oct 17, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

It looks like using :ref: for parameters doesn't work cross-file (e.g., in news entries). After looking at other examples, it seems the right thing to do here is to use `` instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka reviewed Oct 17, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2024-10-16-04-50-53.gh-issue-125542.vZJ-Ns.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
Update Misc/NEWS.d/next/Library/2024-10-16-04-50-53.gh-issue-125542.v…
f43f6f2 
…ZJ-Ns.rst
serhiy-storchaka
serhiy-storchaka approved these changes Oct 17, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 17, 2024
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) October 17, 2024 08:48
@serhiy-storchaka
serhiy-storchaka merged commit 7b04496 into python:main Oct 17, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 17, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@savannahostrowski @ebonnal
pythongh-125542: Deprecate prefix_chars in ArgumentParser.add_argumen…
2cefcd9 
…t_group() (pythonGH-125563)
donbarbos added a commit to donbarbos/typeshed that referenced this pull request Jul 18, 2025
@donbarbos
[argparse] Deprecate prefix_chars in `ArgumentParser.add_argument_g…
a1cab28 
…roup`

Source: python/cpython#125563
@donbarbos donbarbos mentioned this pull request Jul 18, 2025
[argparse] Deprecate prefix_chars in ArgumentParser.add_argument_group python/typeshed#14428
Merged
@donbarbos donbarbos mentioned this pull request Dec 26, 2025
Add Argument Group 3.14 prefix_chars Deprecation python/typeshed#15175
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@savannahostrowski @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.