GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-127133: Remove ability to nest argument groups & mutually exclusive groups by savannahostrowski · Pull Request #127186 · python/cpython

Conversation

@savannahostrowski

@savannahostrowski savannahostrowski commented Nov 23, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR removes the ability to:

  • Call add_argument_group on an argument group
  • Call add_argument_group or add_mutually_exclusive_group on a mutually exclusive group

We have been warning users of this deprecation since 3.11.

  • Issue: Raise exception when nesting argument groups and mutually exclusive groups #127133

📚 Documentation preview 📚: https://cpython-previews--127186.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
savannahostrowski added 2 commits November 22, 2024 19:40
@savannahostrowski
Remove functionality and update docs
e9bf875
@savannahostrowski
Change error type
41464a5
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 23, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 23, 2024
Raise exception when nesting argument groups and mutually exclusive groups #127133
Closed
savannahostrowski
savannahostrowski commented Nov 23, 2024
View reviewed changes
Comment thread Lib/argparse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
blurb-it Bot and others added 3 commits November 23, 2024 04:54
@blurb-it
📜🤖 Added by blurb_it.
b9f3e4d
@savannahostrowski
Add PR number
76aadc6
@savannahostrowski
Merge branch 'main' into pythongh-127133
17556c0
@savannahostrowski

savannahostrowski commented Nov 23, 2024

Copy link
Copy Markdown
Member Author

@iritkatriel Perhaps you can take a look at this one if you've got bandwidth, since you added the original deprecation warnings ☺️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski

savannahostrowski commented Nov 23, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Hmm, let me double-check that there aren't other formatting simplifications we can make now as a result of dropping this.

I took a look and ran branch coverage with a couple of different programs, and nothing stood out to me, so I think it's fine to proceed with this and then tackle any other potential refactorings in separate PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski
savannahostrowski marked this pull request as draft November 23, 2024 05:07
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 23, 2024
@savannahostrowski
Fix sphinx
1673277
@savannahostrowski
savannahostrowski marked this pull request as ready for review November 23, 2024 06:06
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 23, 2024
savannahostrowski added 3 commits November 22, 2024 22:11
@savannahostrowski
Fix refs in whatsnew
baed27b
@savannahostrowski
Fix references in news entry
813a2f5
@savannahostrowski
precommit
6c837ab
iritkatriel
iritkatriel reviewed Nov 23, 2024
View reviewed changes
Comment thread Lib/test/test_argparse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/argparse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/argparse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/argparse.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski and others added 3 commits November 23, 2024 19:09
@savannahostrowski @iritkatriel
Apply suggestions from code review
d835745 
Co-authored-by: Irit Katriel <[email protected]>
@savannahostrowski
Reframe docs to focus on exception
9708536
@savannahostrowski
Fix test exception messages
c55dbee
@savannahostrowski savannahostrowski linked an issue Nov 24, 2024 that may be closed by this pull request
Raise exception when nesting argument groups and mutually exclusive groups #127133
Closed
@savannahostrowski savannahostrowski changed the title GH-127133: Remove ability to nest argument groups and mutex groups GH-127133: Remove ability to nest argument groups & mutually exclusive groups Nov 24, 2024
iritkatriel
iritkatriel approved these changes Nov 24, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 24, 2024
@iritkatriel
iritkatriel enabled auto-merge (squash) November 24, 2024 15:20
@iritkatriel
iritkatriel merged commit 2104bde into python:main Nov 24, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 24, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@savannahostrowski @ebonnal
pythonGH-127133: Remove ability to nest argument groups & mutually ex…
9f87a05 
…clusive groups (python#127186)
@abus-sh abus-sh mentioned this pull request Sep 24, 2026
python314Packages.base64io: fix test_base64io_decode_readlines test NixOS/nixpkgs#566228
Merged
7 of 13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Raise exception when nesting argument groups and mutually exclusive groups

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@savannahostrowski @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.