GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127629: Add ctypes to the Emscripten build by hoodmane · Pull Request #127683 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Dec 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Emscripten: Add ctypes to the Emscripten build #127629

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-127629: Add ctypes to the Emscripten build
d9b6e9b
@hoodmane
hoodmane requested review from brettcannon and freakboy3742 as code owners December 6, 2024 11:46
@bedevere-app bedevere-app Bot mentioned this pull request Dec 6, 2024
Emscripten: Add ctypes to the Emscripten build #127629
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Dec 6, 2024
@hoodmane
hoodmane removed the request for review from brettcannon December 6, 2024 11:47
@hoodmane hoodmane added the OS-emscripten label Dec 6, 2024
hoodmane and others added 2 commits December 6, 2024 12:47
@hoodmane
Add news
8172368
@freakboy3742
Merge branch 'main' into emscripten-ctypes
91a70b3
freakboy3742
freakboy3742 requested changes Dec 9, 2024
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, this works fine; a couple of questions inline about documentation and gross structure.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tools/wasm/emscripten/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/wasm/emscripten/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/wasm/emscripten/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Dec 9, 2024
@bedevere-app

bedevere-app Bot commented Dec 9, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hoodmane added 3 commits December 9, 2024 19:39
@hoodmane
Use release libffi
a3f4891
@hoodmane
Distinguish between build and prefix directories
556de1e
@hoodmane
Add separate make-libffi step to readme
f670c21
@hoodmane

hoodmane commented Dec 9, 2024

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again. Thanks @freakboy3742!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Dec 9, 2024
@bedevere-app

bedevere-app Bot commented Dec 9, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from freakboy3742 December 9, 2024 19:06
freakboy3742
freakboy3742 approved these changes Dec 10, 2024
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for those fixes - this looks great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting change review labels Dec 10, 2024
@freakboy3742
freakboy3742 merged commit 3b18af9 into python:main Dec 10, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 10, 2024
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127629: Add ctypes to the Emscripten build (python#127683)
655b380 
Adds tooling to build libffi and add ctypes to the stdlib for Emscripten.
MichaelBuhler
MichaelBuhler reviewed Apr 8, 2025
View reviewed changes
Comment thread Tools/wasm/emscripten/make_libffi.sh
export EM_PKG_CONFIG_PATH="$PKG_CONFIG_PATH"

# Specific variables for cross-compilation
export CHOST="wasm32-unknown-linux" # wasm32-unknown-emscripten

@MichaelBuhler MichaelBuhler Apr 8, 2025

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this end up being wasm32-unknown-linux instead of wasm32-unknown-emscripten?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@hoodmane hoodmane Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Maybe I put it that way while debugging and didn't notice before merging.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
+1 more reviewer
@MichaelBuhler MichaelBuhler MichaelBuhler left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-emscripten

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hoodmane @freakboy3742 @MichaelBuhler
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.