GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113081: Highlight source code in pdb by gaogaotiantian · Pull Request #133355 · python/cpython

Conversation

@gaogaotiantian

@gaogaotiantian gaogaotiantian commented May 3, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

With #131507, we have some convenient interface to colorize a piece of code. We are so close to beta freeze so I'm not trying to achieve some full colorization on pdb. This PR introduces the most essential and simple piece - static source code. Basically it only colorizes source code display like ll, l, source, where and the initial stack entry display. I think the ROI is great here.

To make it safe for debuggers based on pdb, this uses the same mechanism as backend - default to False, and only enabled when pdb is explicitly brought up by breakpoint() or python -m pdb. The debuggers that inherit pdb won't be affected.

The double protection from if self.colorize is intentional - we don't know what could happen in the future so I used it for both _colorize_code and in the functions that call it.

  • Issue: Colorize pdb #113081

📚 Documentation preview 📚: https://cpython-previews--133355.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gaogaotiantian
Highlight source code in pdb
32907da
@bedevere-app bedevere-app Bot mentioned this pull request May 3, 2025
Colorize pdb #113081
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 3, 2025
@blurb-it
📜🤖 Added by blurb_it.
9b8c2b0
tomasr8
tomasr8 reviewed May 3, 2025
View reviewed changes
Comment thread Lib/pdb.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

gaogaotiantian added 2 commits May 3, 2025 14:56
@gaogaotiantian
Limit split
9da9d33
@gaogaotiantian
Add whatsnew entry
4a9aeee
@gaogaotiantian
gaogaotiantian requested review from ambv and iritkatriel May 3, 2025 18:58
@gaogaotiantian
Force nocolor test
1a9d20e
@gaogaotiantian

gaogaotiantian commented May 5, 2025

Copy link
Copy Markdown
Member Author

Hi @ambv , I know it's kind of last minute feature, but I do think it is very cool to syntax-highlight the code in pdb. You are super familiar with the colorization part and I'm just using the existing interface (I hope it's correct). Could you take a look at it? Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv

ambv commented May 5, 2025

Copy link
Copy Markdown
Contributor

Excellent, I was thinking that you might want to do that. Looks great!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv
ambv merged commit ff4959b into python:main May 5, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label May 5, 2025
@gaogaotiantian
gaogaotiantian deleted the colorize-pdb-list branch May 5, 2025 17:49
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@gaogaotiantian @Pranjal095
pythongh-113081: Highlight source code in pdb (python#133355)
7c19d65
@gpshead gpshead mentioned this pull request Dec 22, 2025
Commit ff4959b for pdb colorization GH-113081 broke some pdb backtraces #142964
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasr8 tomasr8 tomasr8 left review comments
@iritkatriel iritkatriel Awaiting requested review from iritkatriel
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gaogaotiantian @ambv @tomasr8
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.