GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133379: Correct usage of `arguments` in error messages by StanFromIreland · Pull Request #133382 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented May 4, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Not quite sure what the title should be for this.

  • Issue: Parameter's error messages say argument instead of parameter #133379

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tpvasconcelos reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@StanFromIreland
Commit
78e0dcb
@StanFromIreland
StanFromIreland requested review from JelleZijlstra, ambv, carljm, lysnikolaou and pablogsal as code owners May 4, 2025 15:47
@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2025
Parameter's error messages say argument instead of parameter #133379
Closed
@bedevere-app bedevere-app Bot added the awaiting review label May 4, 2025
JelleZijlstra
JelleZijlstra approved these changes May 4, 2025
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title looks great to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland and larsblumberg reacted with heart emoji
All reactions
  • ❤️ 2 reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 4, 2025
picnixz
picnixz approved these changes May 4, 2025
View reviewed changes
@picnixz

picnixz commented May 4, 2025

Copy link
Copy Markdown
Member

The title could be about correcting the places where the term argument is incorrectly used, but your title is fine.
StanFromIreland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz mentioned this pull request May 9, 2025
gh-133436: Correct error messages that incorrectly use "arguments" #133463
Closed
@serhiy-storchaka

serhiy-storchaka commented May 9, 2025

Copy link
Copy Markdown
Member

What is the difference between #133382 and #133463?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented May 9, 2025

Copy link
Copy Markdown
Member Author

Other error messages are corrected.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented May 9, 2025

Copy link
Copy Markdown
Member

Following #133463 (comment), I suggest we fix everything here.
StanFromIreland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland and others added 4 commits May 9, 2025 15:47
@StanFromIreland
Add
e545b78
@StanFromIreland
Cover more incorrect error messages
05ed305
@StanFromIreland
Merge branch 'main' into correct-errors
a30e12a
@StanFromIreland
3.15 entry
1220983
@StanFromIreland

StanFromIreland commented May 9, 2025

Copy link
Copy Markdown
Member Author

All complete, I included @serhiy-storchaka extra example and two more I found. Added an entry to whatsnew since this affects quite a few error messages.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes May 10, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@serhiy-storchaka
serhiy-storchaka merged commit dbca27c into python:main May 10, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 10, 2025
@StanFromIreland
StanFromIreland deleted the correct-errors branch May 10, 2025 12:02
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@StanFromIreland @Pranjal095
pythongh-133379: Fix misuse of the term "arguments" in error messages (…
332d44c 
…pythonGH-133382)

The right term is "parameters".
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@StanFromIreland @taegyunkim
pythongh-133379: Fix misuse of the term "arguments" in error messages (…
3e82f21 
…pythonGH-133382)

The right term is "parameters".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@picnixz picnixz picnixz approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner
@carljm carljm Awaiting requested review from carljm carljm is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@StanFromIreland @picnixz @serhiy-storchaka @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.