GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — gh-133447: Add basic color to `sqlite3` CLI by StanFromIreland · Pull Request #133461 · python/cpython Conversation
|
|
Now that #133347 has been merged, we could take advantage of it in the sqlite CLI as well? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
cc @ambv Just to check -- did I use themes correctly or did I do something wrong (there is no docs at the moment to verify)? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there are no docs so I'll push here with how I'd do it if that's okay.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Let me know what you think.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Looks good to me now, thank you for the assistance:-) If you need help with colorise I’d be happy to lend a hand. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Excellent! Since all this is already for 3.15, I think we might attempt a SQL syntax highlighter as well, although I'm not entirely sure our tokenizer will take kindly to it, so this might become a larger task. We have plenty of time, though. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
sqlite3 clisqlite3 CLI
There was an error while loading. Please reload this page.
Co-authored-by: Erlend E. Aasland <[email protected]>
SQL highlighting would be awesome. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
All the test fails are unrelated.
Working on it :-) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@StanFromIreland, please look into the failing tests. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I was testing the broken behavior that was now fixed, oops! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@erlend-aasland Test has been corrected to work with the new updates. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Unrelated. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
(pythongh-133447: Add basic color to `sqlite3` CLI (python#133461))
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.