GeezerVison is showing github.com — GH-135904: Improve the JIT's performance on macOS by brandtbucher · Pull Request #136528 · python/cpython
Conversation
brandtbucher
commented
Jul 11, 2025
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
This PR makes a couple of minor tweaks to the JIT that result in 1.7% faster performance on macOS overall:
- Our AArch64 code doesn't need to be 8-byte aligned, just the data. Currently, we guarantee this by aligning all code anyways, since the data follows immediately after it. This is wasteful, since it means about half of all stencils end in a
nop. Instead, don't pad any stencils, and just align the data when it's compiled. 🤦🏼
- The textual assembly "optimizer" pass has a bug where it interprets lines that are commented with
; as instructions. By recognizing these commented lines, we can remove more zero-length jumps at the end of stencils. 🤦🏼
- During this same pass, we can represent the address of the next instruction (the end of the template, or the
_JIT_CONTINUE label) as a "local" label, which allows the assembler to resolve it at compile time and encode it more efficiently. There's a special (platform-dependent) prefix to signal this.
- Finally, instead of declaring jump targets (
_JIT_CONTINUE, _JIT_ERROR_TARGET, and _JIT_JUMP_TARGET) as extern symbols, just declare them as local functions. This results in more efficient jumps (and also allows us to remove a somewhat hacky pre-processing step for the textual assembly on Windows to force these efficient jumps).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Fidget-Spinner, Genarito, Sacul0457, and CarlosEduR reacted with rocket emoji
|
This is amazing! I can't review it, but thanks for all your assembler wizardry on this.
|
brandtbucher reacted with heart emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The PR looks great, thanks for making the JIT so much clearer to reason about.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
brandtbucher reacted with heart emoji
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|