GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — gh-140942: Add MIME type for .cjs extension by johnfraney · Pull Request #140937 · python/cpython Conversation
|
Thanks for the review, @StanFromIreland! I updated this PR to add the extension to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
IANA says https://www.iana.org/assignments/media-types/application/node
And this makes no mention of the MIME type. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for the update. And because this is actually registered with IANA, we can put it in the regular list. Please also don't force push in this repo, it makes it a bit harder to review changes. We squash merge anyway at the end. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@hugovk That's a good point about force-pushing. Thank you for your help! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Please add to the first in the mimetypes list at https://docs.python.org/3.15/whatsnew/3.15.html#mimetypes
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Adds .cjs mimetype of `text/javascript` for CommonJS modules to common_types. See here for more information: https://nodejs.org/api/modules.html#enabling
…e-140942.GYns6n.rst Add changes to news entry from code review Co-authored-by: Hugo van Kemenade <[email protected]>
|
Reminder about these things :)
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@hugovk Oh, weird, I think my local repo had an issue because I checked out with a depth of 1 and |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Add .cjs to mimetypes
There was an error while loading. Please reload this page.