Description

assignee = None
closed_at = <Date 2002-09-25.19:22:58.000>
created_at = <Date 2002-08-06.19:26:03.000>
labels = ['library']
title = 'Fix "file:" URL to have right no. of /\'s'
updated_at = <Date 2002-09-25.19:22:58.000>
user = 'https://bugs.python.org/callenish'

activity = <Date 2002-09-25.19:22:58.000>
actor = 'nnorwitz'
assignee = 'nnorwitz'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2002-08-06.19:26:03.000>
creator = 'callenish'
dependencies = []
files = ['4487']
hgrepos = []
issue_num = 591713
keywords = ['patch']
message_count = 4.0
messages = ['40855', '40856', '40857', '40858']
nosy_count = 3.0
nosy_names = ['fdrake', 'nnorwitz', 'callenish']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue591713'
versions = []

Activity

1. callenish commented on Aug 6, 2002

   

   callenishmannequin

   on Aug 6, 2002

   MannequinAuthor

   More actions

   If you run urlparse.urljoin() on a file: URL, the resulting URL
   has together with the wrong number of '/'s in it.

   Properly formed, the URL (assuming no netloc) should have
   three slashes, so that it looks like "file:///...". The current
   code drops that down to one.

   The error appears to be in a condition in urlunsplit(). It
   doesn't show up except in this one instance because the
   test is only run iff the scheme is in the list of those that can
   take a netloc and there is no netloc present in the URL.
   Apparently, this is pretty rare.

   Patch attached that corrects the condition.
2. callenish

   closed this as completedon Aug 6, 2002
3. callenish

   assigned

   nnorwitz

   on Aug 6, 2002
4. callenish

   added

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   on Aug 6, 2002
5. nnorwitz commented on Sep 17, 2002

   

   nnorwitzmannequin

   on Sep 17, 2002

   Mannequin

   More actions

   Logged In: YES
   user_id=33168

   Not sure who is best to review this? Fred? Jeremy?
   Someone else?

   This patch works for me. I have a test too. Assign back to
   me if you want me to check it in.
6. freddrake commented on Sep 25, 2002

   

   freddrake

   on Sep 25, 2002

   Member

   More actions

   Logged In: YES
   user_id=3066

   Looks good to me; go ahead and check it in with the tests.

   Thanks!
7. nnorwitz commented on Sep 25, 2002

   

   nnorwitzmannequin

   on Sep 25, 2002

   Mannequin

   More actions

   Logged In: YES
   user_id=33168

   Checked in as:

   • urlparse.py 1.33 and 1.31.6.2
   • test_urlparse.py 1.7 and 1.2.24.2
   • output/test_urlparse 1.2.24.2
8. ezio-melotti

   transferred this issue fromon Apr 9, 2022

Issue actions