Description

assignee = None
closed_at = <Date 2017-02-26.16:04:48.886>
created_at = <Date 2016-12-31.16:04:55.057>
labels = ['type-bug', '3.7', 'docs']
title = 'sqlite3 Controlling Transactions documentation not updated'
updated_at = <Date 2017-03-24.23:41:51.182>
user = 'https://github.com/palaviv'

activity = <Date 2017-03-24.23:41:51.182>
actor = 'berker.peksag'
assignee = 'docs@python'
closed = True
closed_date = <Date 2017-02-26.16:04:48.886>
closer = 'berker.peksag'
components = ['Documentation']
creation = <Date 2016-12-31.16:04:55.057>
creator = 'palaviv'
dependencies = []
files = ['46101']
hgrepos = []
issue_num = 29121
keywords = ['patch']
message_count = 7.0
messages = ['284396', '286217', '286293', '288598', '290379', '290388', '290389']
nosy_count = 6.0
nosy_names = ['ghaering', 'docs@python', 'berker.peksag', 'serhiy.storchaka', 'malin', 'palaviv']
pr_nums = ['313', '319']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue29121'
versions = ['Python 3.6', 'Python 3.7']

Activity

1. palaviv commented on Dec 31, 2016

   

   palavivmannequin

   on Dec 31, 2016

   MannequinAuthor

   More actions

   commit 284676cf2ac8 changed the sqlite3 module so it will no longer implicitly commit an open transaction before DDL statements. The docs have been updated but there is still an incorrect paragraph that has not been removed.
   Attached is a patch that remove the old paragraph.
2. palaviv

   added

   3.7 (EOL)end of lifeend of life

   on Dec 31, 2016
3. palaviv commented on Jan 24, 2017

   

   palavivmannequin

   on Jan 24, 2017

   MannequinAuthor

   More actions

   I would just like to note that I think that the correct solution is to do an implicit commit before:

   1. VACUUM
   2. ATTACH
   3. DETACH
   4. BEGIN
4. animalize commented on Jan 26, 2017

   

   animalizemannequin

   on Jan 26, 2017

   Mannequin

   More actions

   After read some issues, there are two major concerns:
   1, backward compatibility.
   2, implicit commit is bad, tolerates bug-prone codes.

   However they are not contradictory if we print a warning when doing an implicit commit. Some messages like this:
   Warning: sqlite3 module issued an implicit commit before executing VACUUM, you should commit this transaction by yourself, that's a good habit, etc..

   Then we can keep backward compatibility, and no longer commit implicitly.
5. berkerpeksag commented on Feb 26, 2017

   

   berkerpeksag

   on Feb 26, 2017

   Member

   More actions

   Thanks for the patch, Aviv!
6. berkerpeksag

   added

   docsDocumentation in the Doc dirDocumentation in the Doc dir

   on Feb 26, 2017
7. berkerpeksag

   closed this as completedon Feb 26, 2017
8. berkerpeksag

   assigned

   docspython

   on Feb 26, 2017
9. berkerpeksag

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Feb 26, 2017
10. berkerpeksag commented on Mar 24, 2017

    

    berkerpeksag

    on Mar 24, 2017

    Member

    More actions

    New changeset 893e86e by Berker Peksag in branch '3.6':
    bpo-29121: Remove outdated documentation about transactions (#313) (#319)
    893e86e
11. berkerpeksag commented on Mar 24, 2017

    

    berkerpeksag

    on Mar 24, 2017

    Member

    More actions

    New changeset fe70d92 by Berker Peksag in branch 'master':
    bpo-29121: Remove outdated documentation about transactions (#313)
    fe70d92
12. berkerpeksag commented on Mar 24, 2017

    

    berkerpeksag

    on Mar 24, 2017

    Member

    More actions

    New changeset fe70d92 by Berker Peksag in branch 'master':
    bpo-29121: Remove outdated documentation about transactions (#313)
    fe70d92
13. ezio-melotti

    transferred this issue fromon Apr 10, 2022

Issue actions