GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Unneeded include in call.c · Issue #93785 · python/cpython

Unneeded include in call.c #93785

New issue
Copy link
New issue
Copy link
Closed
Closed
Unneeded include in call.c#93785
Copy link

Description

@pamelafox
pamelafox
opened on Jun 13, 2022
Issue body actions

Bug report

Objects/call.c has:

#include "frameobject.h" // _PyFrame_New_NoTrack()

However, it no longer uses _PyFrame_New_NoTrack - that was removed in PR #24368
https://github.com/python/cpython/pull/24368/files#diff-b876797aa8c96d633b0b869447e7e14da64b9f53e48561149446939e7c6257e9

It also does not use any other functions from frameobject.h, and CPython compiles fine without it.

I will send a PR shortly with its removal.

Your environment

  • CPython versions tested on: main branch
  • Operating system and architecture: Mac OS X

Activity

  1. pamelafox
    added
    type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
    on Jun 13, 2022
  2. iritkatriel
    removed
    type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
    on Jun 14, 2022

  3. kumaraditya303 commented on Jun 15, 2022

    @kumaraditya303
    kumaraditya303
    on Jun 15, 2022
    Contributor
    More actions

    Fixed by #93786

  4. kumaraditya303
    closed this as completedon Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.