GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95077: [Enum] add code-based deprecation warnings for member.member access by ethanfurman · Pull Request #95083 · python/cpython

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Jul 21, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The performance speed-up added in 3.11 is removed as other improvements in Python have made it unnecessary. With that removal, it is now possible to detect when a member.member access is attempted, and issue a warning before returning the desired member.


Each enum member is represented in the enum class dict by a custom enum.property. The enum member itself lives in both _member_map_ and enum.property, enabling enum.property to skip the _member_map_ lookup.

enum.property is a subclass of types.DynamicClassAttribute to enable inspect, etc., to properly investigate and document enum members and attributes (although enum.property works completely differently).

  • Issue: [Enum] Deprecate member.member access with removal in 3.14 #95077

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ethanfurman added 4 commits July 20, 2022 14:10
@ethanfurman
always store member property in current class
d20226c
also remove __getattr__
@ethanfurman
issue deprecation warning for member.member access
a81c0e5
@ethanfurman
remove __getattr__ from docs
6a980de
@ethanfurman
update docs
01acf3c
@bedevere-bot bedevere-bot added the awaiting core review label Jul 21, 2022
@ethanfurman ethanfurman self-assigned this Jul 21, 2022
@ethanfurman ethanfurman added type-feature A feature request or enhancement 3.12 only security fixes stdlib Standard Library Python modules in the Lib/ directory labels Jul 21, 2022
ethanfurman and others added 5 commits July 21, 2022 15:37
@ethanfurman
add news entry
27e5141
@ethanfurman
rename NEWS file back to bpo
1c158b5
@ethanfurman
trying to figure out correct file name for NEWS entry
e85af4c
@ethanfurman
remove faulty news file
b7659d8
@blurb-it
📜🤖 Added by blurb_it.
f1412a9
@ethanfurman
ethanfurman merged commit 4e704d7 into python:main Jul 25, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 25, 2022
@ethanfurman
ethanfurman deleted the enum-restricted branch November 23, 2022 23:52
@coderabbitai coderabbitai Bot mentioned this pull request May 7, 2026
Honour package version overwrites in BDBA extension open-component-model/odg-core#778
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ethanfurman ethanfurman

Labels

3.12 only security fixes stdlib Standard Library Python modules in the Lib/ directory type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ethanfurman @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.