GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-99729: Unlink frames before clearing them by brandtbucher · Pull Request #100047 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Dec 6, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a manual backport of the not-yet-merged #100030.

That one should happen first, but I thought I'd get this ready while the buildbots ran.

  • Issue: Frame teardown can create frame objects #99729

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 4 commits November 26, 2022 05:31
@brandtbucher
Add failing regression test
3586f17
@brandtbucher
Unlink frames before clearing them
5b71873
@brandtbucher
blurb add
b776d3b
@brandtbucher
Require working threading for new test
5314243
@brandtbucher brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump labels Dec 6, 2022
@brandtbucher brandtbucher self-assigned this Dec 6, 2022
@brandtbucher
brandtbucher requested a review from markshannon as a code owner December 6, 2022 00:57
@bedevere-bot bedevere-bot mentioned this pull request Dec 6, 2022
Frame teardown can create frame objects #99729
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Dec 6, 2022
@markshannon

markshannon commented Dec 6, 2022

Copy link
Copy Markdown
Member

Looks good.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 6, 2022
@bedevere-bot

bedevere-bot commented Dec 6, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 5314243 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 6, 2022
@markshannon markshannon assigned pablogsal Dec 6, 2022
@brandtbucher brandtbucher mentioned this pull request Dec 6, 2022
GH-99729: Unlink frames before clearing them #100030
Merged
@vstinner

vstinner commented Dec 6, 2022

Copy link
Copy Markdown
Member

I'm curious about "Refleaks" buildbot timings ("Total duration"):

  • AMD64 Fedora Stable Refleaks PR: 46 min 9 sec
  • AMD64 RHEL7 Refleaks PR: 39 min
  • PPC64LE Fedora Stable Refleaks PR: 36 min 12 sec
  • PPC64LE RHEL8 Refleaks PR: 40 min 31 sec
  • aarch64 Fedora Stable Refleaks PR: 40 min 42 sec
  • aarch64 RHEL8 Refleaks PR: 50 min 24 sec
  • s390x Fedora Refleaks PR: 40 min 20 sec
  • s390x RHEL7 Refleaks PR: 56 min 46 sec
  • s390x RHEL8 Refleaks PR: 36 min 57 sec

On-going: PPC64LE RHEL7 Refleaks PR (26 min).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher

brandtbucher commented Dec 6, 2022

Copy link
Copy Markdown
Member Author

I'm away from my computer for the next hour or so, so feel free to merge when ready.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Dec 6, 2022

Copy link
Copy Markdown
Member

I'm curious about "Refleaks" buildbot timings ("Total duration"):

  • AMD64 Fedora Stable Refleaks PR: 46 min 9 sec
  • AMD64 RHEL7 Refleaks PR: 39 min
  • PPC64LE Fedora Stable Refleaks PR: 36 min 12 sec
  • PPC64LE RHEL8 Refleaks PR: 40 min 31 sec
  • aarch64 Fedora Stable Refleaks PR: 40 min 42 sec
  • aarch64 RHEL8 Refleaks PR: 50 min 24 sec
  • s390x Fedora Refleaks PR: 40 min 20 sec
  • s390x RHEL7 Refleaks PR: 56 min 46 sec
  • s390x RHEL8 Refleaks PR: 36 min 57 sec

On-going: PPC64LE RHEL7 Refleaks PR (26 min).

What's curious about this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 2182a71 into python:3.11 Dec 6, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 6, 2022
@vstinner

vstinner commented Dec 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

What's curious about this?

On Discord, @markshannon wrote that " PPC64LE RHEL7 Refleaks PR" took "forever" :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented Dec 7, 2022

Copy link
Copy Markdown
Member

The problem is not that the individual runs take a long time, but that one overworked machine is running many of them, so collectively they take "forever" (actually a few hours)
https://buildbot.python.org/all/#/workers/6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Dec 7, 2022

Copy link
Copy Markdown
Member

https://buildbot.python.org/all/#/workers/6

I looked at the latest 10 builds. They waited between 1 second and 30 minutes, and the slowest took 1 hour (Refleaks build, tests took 50 min).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@brandtbucher @markshannon @bedevere-bot @vstinner @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.