GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99941: asyncio.Protocol.data_received now received immutable bytes by DarioDaF · Pull Request #100053 · python/cpython

Conversation

@DarioDaF

@DarioDaF DarioDaF commented Dec 6, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Made asyncio.Protocol.data_received receive immutable object
bytes instead of bytearrays (like defined in the docs) with regression tests added
and opted to use memoryview to take the slices for performance on big buffers.

Performance test from #21442 done on my machine with 10
repetitions on release build with timings 0.043 (delta: 0.019) before patch
and 0.041 (delta: 0.010) after so no noticable change in performance.

  • Issue: asyncio tcp transport on Windows reads bytearray instead of bytes #99941

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
DarioDaF added 3 commits December 6, 2022 09:55
@DarioDaF
Moving transport data_read to bytes through memoryview
aad3337
@DarioDaF
Added test case for python#99941
1a5af35
@DarioDaF
Added blurb
d9e22f7
@DarioDaF
DarioDaF requested review from 1st1, asvetlov, gvanrossum and kumaraditya303 as code owners December 6, 2022 10:22
@bedevere-bot bedevere-bot mentioned this pull request Dec 6, 2022
asyncio tcp transport on Windows reads bytearray instead of bytes #99941
Closed
@bedevere-bot bedevere-bot added the awaiting review label Dec 6, 2022
@ghost

ghost commented Dec 6, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303

kumaraditya303 commented Dec 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@gvanrossum Is this what you intended? I thought that we were going for a documentation update and some unittests though I might be misunderstanding. If this is to be accepted then we need more benchmarks with larger payloads to verify.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum
gvanrossum approved these changes Dec 10, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits for the news entry. I'll apply that and then merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

DarioDaF reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Misc/NEWS.d/next/Windows/2022-12-06-11-16-46.gh-issue-99941.GmUQ6o.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 10, 2022
@gvanrossum
Simplify news entry
e101911
@python python deleted a comment from netlify Bot Dec 10, 2022
@gvanrossum
gvanrossum merged commit 1bb68ba into python:main Dec 10, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 10, 2022
@kumaraditya303 kumaraditya303 mentioned this pull request Dec 14, 2022
Add asyncio_tcp benchmark python/pyperformance#254
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@DarioDaF @kumaraditya303 @gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.