GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-93453: Only emit deprecation warning in asyncio.get_event_loop when a new event loop is created by ambv · Pull Request #100059 · python/cpython

Conversation

@ambv

@ambv ambv commented Dec 6, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

It no longer emits a deprecation warning if the current event loop was set.

(cherry picked from commit 3fae04b)

Co-authored-by: Serhiy Storchaka [email protected]
Co-authored-by: Łukasz Langa [email protected]

Note: this backport also contains a change to tests_asyncio.test_tasks.BaseTaskTests.test_as_completed_coroutine_use_global_loop which was later removed in GH-31964 by Yury so is absent from Serhiy's changes to 3.11 and 3.12.

  • Issue: Finish deprecation in asyncio.get_event_loop() #93453

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @ambv
[3.10] [3.11] pythongh-93453: Only emit deprecation warning in asynci…
41e6a4c 
…o.get_event_loop when a new event loop is created (pythonGH-99949)

It no longer emits a deprecation warning if the current event loop was set.

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 3fae04b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@ambv
ambv requested review from 1st1 and asvetlov as code owners December 6, 2022 15:48
@bedevere-bot bedevere-bot mentioned this pull request Dec 6, 2022
Finish deprecation in asyncio.get_event_loop() #93453
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Dec 6, 2022
ambv
ambv commented Dec 6, 2022
View reviewed changes
Comment thread Doc/library/asyncio-policy.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv requested a review from serhiy-storchaka December 6, 2022 15:52
serhiy-storchaka
serhiy-storchaka approved these changes Dec 6, 2022
View reviewed changes
Comment thread Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/asyncio-policy.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_asyncio/test_tasks.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 6, 2022
@ambv
Restore accidentally removed test content, change mentions of 3.11 to…
9994a6e 
… 3.10
serhiy-storchaka
serhiy-storchaka approved these changes Dec 6, 2022
View reviewed changes
@ambv
ambv merged commit 300d812 into python:3.10 Dec 6, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 6, 2022
@ambv
ambv deleted the backport-3fae04b-3.10 branch December 6, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ambv @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.