GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — gh-100072: only trigger netlify builds for doc changes by sobolevn · Pull Request #100074 · python/cpython Conversation
|
✅ Deploy Preview for python-cpython-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks! Looks like it needs a bit of tuning. I added this to my fork's Then created two PRs inside my fork, one with a But Netlify built both. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hm, maybe like this? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Added that to my fork's Rebased the two PRs but both had Netlify builds. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This command should work: git diff --name-only | grep -q '^Doc/' && exit 1 || exit 0
Prep: echo 'a' >> Doc/glossary.rst Local tests (I use » git diff --name-only | grep -q '^Lib/' && echo 1 || echo 0 0 » git diff --name-only | grep -q '^Doc/' && echo 1 || echo 0 1 Do you agree? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
With local testing, yes. With Netlify, no... hugovk@abbc30d shows "Deploy Preview canceled." for both PRs... hugovk#34 with no docs change: hugovk#35 with docs change: Rewinding and looking at the logs for #100074 (comment): hugovk#34 without docs change: hugovk#35 with docs change: So we've already set
So let's try I also cleared the deploy caches, in case the rebase/force pushes hugovk#34 without docs change - no Netlify build! ✅: hugovk#35 with docs change - has Netlify build! ✅: So let's try this! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <[email protected]>
|
Thanks, |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thank you, let's give this a shot!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you for testing and finding a solution ;) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.