GeezerVison is showing github.com — GH-98831: Get rid of super(), just use macro() by gvanrossum · Pull Request #100095 · python/cpython
Conversation
gvanrossum
commented
Dec 8, 2022
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Instead of super(X) = Y + Z write macro(X) = Y + JOIN + Z and get rid of the code duplication for super and macro.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This doesn't really make things much cleaner, but it works.
This was more convoluted than I expected.
Also removed some dead code from the former
(somehow the case for CacheEffect had crept back in).
This makes the PEEK/POKE sequences less jarring.
STORE_SUBSCR was alread half converted,
but wasn't using cache effects yet.
The original had mysterious `SET_TOP(NULL)` before `goto error`.
I assume those just account for `obj` having been decref'ed,
so I got rid of them in favor of the cleanup implied by `ERROR_IF()`.
This should fix the build crash on Windows.
netlify
Bot
commented
Dec 8, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
✅ Deploy Preview for python-cpython-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
markshannon
Awaiting requested review from markshannon
markshannon will be requested when the pull request is marked ready for review
markshannon is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.