GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-98831: Generate things in the input order by gvanrossum · Pull Request #100123 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Dec 8, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This makes it easier to see what changed in the generated code when converting an instruction to super or macro.

This PR only changes the placement of all super- and macro instructions in the output. There should be no semantic changes (Python/bytecodes.c is unchanged). The changes to the generator are minimal.

  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
Generate things in the input order
e838193 
This makes it easier to see what changed in the generated code
when converting an instruction to super or macro.
@netlify

netlify Bot commented Dec 8, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit e838193
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/63926f11a8811f0009e20de7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Dec 8, 2022
Generate the interpreter #98831
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Dec 8, 2022
@gvanrossum
gvanrossum requested a review from brandtbucher December 8, 2022 23:11
@gvanrossum gvanrossum mentioned this pull request Dec 8, 2022
GH-98831: Remove super-instruction definitions, use macro instructions instead #100124
Closed
brandtbucher
brandtbucher approved these changes Dec 8, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 8, 2022
@gvanrossum gvanrossum added the skip news label Dec 8, 2022
@gvanrossum
gvanrossum merged commit 1cfa704 into python:main Dec 8, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 8, 2022
@gvanrossum
gvanrossum deleted the reorder-supers-macros branch December 8, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gvanrossum @brandtbucher @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.