GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99533: Fix issue where email.generator.Generator ignores policy when using multipart/signed by jackpendley · Pull Request #100204 · python/cpython

Conversation

@jackpendley

@jackpendley jackpendley commented Dec 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Provides fix for Issue #99533

The requested fix in the original issue report was implemented.

Removed _handle_multipart_signed from generator.py altogether so the headers folding no longer changes when accessing the whole message at once

  • Issue: email.generator.Generator ignores policy when using multipart/signed → ruins signing #99533

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
jackpendley added 2 commits December 12, 2022 15:28
@jackpendley
Removed def _handle_multipart_signed from generator.py file to solve …
0e07b96
…issue python#99533 where EmailMessage behaves differently when being set to multipart/signed mimetype
@jackpendley
Added unit test to test_email.py to ensure removing def _handle_multi…
6458267
…part_signed would resolve issue python#99533
@jackpendley
jackpendley requested a review from a team as a code owner December 13, 2022 00:18
@bedevere-bot bedevere-bot mentioned this pull request Dec 13, 2022
email.generator.Generator ignores policy when using multipart/signed → ruins signing #99533
Open
@bedevere-bot bedevere-bot added the awaiting review label Dec 13, 2022
@bedevere-bot

bedevere-bot commented Dec 13, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@netlify

netlify Bot commented Dec 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit 0058a1e
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6397c86f676f720008e6cfc9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost

ghost commented Dec 13, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

blurb-it Bot and others added 2 commits December 13, 2022 00:31
@blurb-it
📜🤖 Added by blurb_it.
77af2cb
@jackpendley
Merge branch 'main' into fix-issue-99533
0058a1e
@bitdancer

bitdancer commented Dec 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Have things been fixed so that unmodified headers are never refolded? If that has been done, then this works. However, if it is still the case that long headers get refolded when rendering an existing (not a new) message, then this will break re-rendering existing signed messages, which was the point of the original fix. The correct fix, obviously, is to never refold header lines that have not been modified since the message was deserialized, which is what I should have done originally (hindsight is wonderful :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@python-cla-bot

python-cla-bot Bot commented Apr 18, 2025

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

  • [email protected]

CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented Apr 12, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 12, 2026
@ambv

ambv commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

This PR has been blocked on an unsigned CLA for more than 12 months and cannot be merged until all commit authors sign. Closing to cull the number of open pull requests. Do not reopen this pull request without signing the CLA first and getting a go-ahead from a triager or core developer on gh-99533.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv ambv closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jackpendley @bedevere-bot @bitdancer @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.