GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-98363: Update batched() recipe in docs to match 3.12 by rhettinger · Pull Request #100323 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented Dec 17, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add itertools.batched() #98363

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rhettinger
Update batched() recipe in docs to match 3.12
dcb1dce
@rhettinger rhettinger added docs Documentation in the Doc dir skip news labels Dec 17, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 17, 2022
Add itertools.batched() #98363
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Dec 17, 2022
@rhettinger
Fix unbalanced bracket
af8ad77
hauntsaninja
hauntsaninja reviewed Dec 17, 2022
View reviewed changes
Comment thread Doc/library/itertools.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach
CAM-Gerlach approved these changes Dec 18, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs perspective, FWIW. Should this be backported to 3.10 as well?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CAM-Gerlach CAM-Gerlach mentioned this pull request Dec 18, 2022
Adjusting the "Triager" role's permissions python/core-workflow#460
Closed
@CAM-Gerlach

CAM-Gerlach commented Dec 18, 2022

Copy link
Copy Markdown
Member

Also, I noticed that though this PR was made from your fork per the usual flow. there is an apparent duplicate https://github.com/python/cpython/tree/batched_recipe_tuple branch on the upstream cpython repo. Does that need to be there, or can it be removed? It's the final blocker to implementing the final step of python/core-workflow#460 on cpython. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger
rhettinger merged commit 0918667 into python:3.11 Dec 18, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 18, 2022
@rhettinger
rhettinger deleted the batched_recipe_tuple branch December 18, 2022 01:10
@rhettinger

rhettinger commented Dec 18, 2022

Copy link
Copy Markdown
Contributor Author

@CAM-Gerlach Yes, go ahead and remove the other branch.
CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@CAM-Gerlach

CAM-Gerlach commented Dec 18, 2022

Copy link
Copy Markdown
Member

Thanks, removed! 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments
@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@rhettinger @CAM-Gerlach @hauntsaninja @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.