GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100321: Remove redundant variable newfree in function analyze_block by zikcheng · Pull Request #100327 · python/cpython

Conversation

@zikcheng

@zikcheng zikcheng commented Dec 18, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Redundant variable newfree in function analyze_block() #100321

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zikcheng
Remove redundant variable newfree in function analyze_block
32fcd32
@bedevere-bot bedevere-bot mentioned this pull request Dec 18, 2022
Redundant variable newfree in function analyze_block() #100321
Closed
@bedevere-bot bedevere-bot added the awaiting review label Dec 18, 2022
@kumaraditya303
kumaraditya303 requested review from iritkatriel and markshannon December 18, 2022 07:13
@kumaraditya303 kumaraditya303 added the skip news label Dec 18, 2022
JosephSBoyle
JosephSBoyle reviewed Dec 18, 2022
View reviewed changes

@JosephSBoyle JosephSBoyle left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.
What do the "newfree" and "allfree" vars represent?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zikcheng

zikcheng commented Dec 18, 2022

Copy link
Copy Markdown
Contributor Author

Hi @JosephSBoyle , in my understanding, allfree represents all free variables in children blocks and newfree is just a copy of allfree.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JosephSBoyle

JosephSBoyle commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

@zikcheng Thanks for clarifying for me:)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Apr 10, 2024

Copy link
Copy Markdown
Member

In #101441, the allfree variable was removed instead.

Sorry that we missed this PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel
@markshannon markshannon Awaiting requested review from markshannon
1 more reviewer
@JosephSBoyle JosephSBoyle JosephSBoyle left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@zikcheng @JosephSBoyle @encukou @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.