GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99908 Update class documentation to use a modernized example by JosephSBoyle · Pull Request #100433 · python/cpython

Conversation

@JosephSBoyle

@JosephSBoyle JosephSBoyle commented Dec 22, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Small update to the docs to improve on an outmoded example from 15 years ago.
The aim of this change is to give readers of the docs a more idiomatic example.

  • Issue: classes odds and ends could mention dataclasses #99908

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot mentioned this pull request Dec 22, 2022
classes odds and ends could mention dataclasses #99908
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 22, 2022
@ghost

ghost commented Dec 22, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

  • [email protected]

Click the button to sign:
CLA not signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JosephSBoyle
JosephSBoyle force-pushed the fix-issue-99908 branch from 278affa to b02d708 Compare December 22, 2022 14:10
@sobolevn

sobolevn commented Dec 22, 2022

Copy link
Copy Markdown
Member

Hi, @JosephSBoyle! Could you please sign a CLA? We cannot accept your PR without it :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JosephSBoyle

JosephSBoyle commented Dec 22, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Hi @sobolevn. I have accepted the CLA. Can you re-run the check please? (I had to change my email address in the commit to my GH one).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JosephSBoyle
JosephSBoyle force-pushed the fix-issue-99908 branch from b02d708 to 299ecee Compare December 22, 2022 20:36
hauntsaninja
hauntsaninja reviewed Dec 23, 2022
View reviewed changes
Comment thread Doc/tutorial/classes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
hauntsaninja
hauntsaninja reviewed Dec 23, 2022
View reviewed changes
Comment thread Doc/tutorial/classes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JosephSBoyle
JosephSBoyle force-pushed the fix-issue-99908 branch from 1ebe525 to d6e1eb9 Compare December 23, 2022 11:47
@sobolevn

sobolevn commented Dec 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@JosephSBoyle are you sure that your git email is the same as your CLA email: [email protected]?
Looks like CLA status is not updated :(
Usually it happens in <1 hour.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JosephSBoyle
JosephSBoyle force-pushed the fix-issue-99908 branch from d6e1eb9 to a3a1750 Compare December 24, 2022 12:50
Joe Boyle and others added 3 commits December 24, 2022 13:09
Joe Boyle @JosephSBoyle
pythongh-99908 Update class documentation to use a modernized example
de102b1
@hauntsaninja @JosephSBoyle
Newline to separate interactive section, like above examples
f97869a
@hauntsaninja @JosephSBoyle
Use interpreter output, not comments, like with Dog example
3021b7c
@JosephSBoyle
JosephSBoyle force-pushed the fix-issue-99908 branch from a3a1750 to 3021b7c Compare December 24, 2022 13:10
@JosephSBoyle

JosephSBoyle commented Dec 24, 2022

Copy link
Copy Markdown
Contributor Author

Hi @sobolevn, thanks for the reminder- I had to rebase and edit my email in the commit log to have the same email as my CLA. Should be fine now:)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Dec 24, 2022

Copy link
Copy Markdown
Member

Hi @sobolevn, thanks for the reminder- I had to rebase and edit my email in the commit log to have the same email as my CLA. Should be fine now:)

Looks like the CLA bot is still being grumpy — it might be easier to just close the PR and recreate it :)
JosephSBoyle reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JosephSBoyle
JosephSBoyle marked this pull request as draft December 24, 2022 13:17
@JosephSBoyle JosephSBoyle closed this Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JosephSBoyle @sobolevn @AlexWaygood @hauntsaninja @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.