GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100488: Add is_integer method to fractions.Fraction by hauntsaninja · Pull Request #100489 · python/cpython

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented Dec 24, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add is_integer to fractions.Fraction #100488

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JozGonzalez reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@hauntsaninja
pythongh-100488: Add is_integer method to fractions.Fraction
626ca91
@bedevere-bot bedevere-bot mentioned this pull request Dec 24, 2022
Add is_integer to fractions.Fraction #100488
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Dec 24, 2022
@hauntsaninja

hauntsaninja commented Dec 24, 2022

Copy link
Copy Markdown
Contributor Author

The documentation guarantees that denominator is in lowest term. It doesn't make any explicit guarantee about being positive, but as_integer_ratio does and just returns the denominator. But do let me know if I should change to abs(self._denominator) == 1 or self._numerator % self._denominator == 0!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blurb-it
📜🤖 Added by blurb_it.
db51a7e
@hauntsaninja
hauntsaninja requested a review from mdickinson December 24, 2022 04:14
@hauntsaninja hauntsaninja mentioned this pull request Dec 24, 2022
Improve duck type compatibility of int with float #100268
Closed
JelleZijlstra
JelleZijlstra approved these changes Dec 24, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(But let's wait for Mark to also give feedback.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 24, 2022
mdickinson
mdickinson approved these changes Dec 29, 2022
View reviewed changes

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; one reST markup nitpick.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/fractions.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja @mdickinson
Update Doc/library/fractions.rst
c542a85 
Co-authored-by: Mark Dickinson <[email protected]>
@hauntsaninja
hauntsaninja merged commit e83f88a into python:main Jan 1, 2023
@hauntsaninja
hauntsaninja deleted the fraction-is-integer branch January 1, 2023 08:44
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
+1 more reviewer
@mdickinson mdickinson mdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hauntsaninja @mdickinson @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.